Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 551043004: Make the ipclist utility aware of two new message files. (Closed)

Created:
6 years, 3 months ago by Tom Sepez
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, gcasto+watchlist_chromium.org, jam, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make the ipclist utility aware of two new message files. Committed: https://crrev.com/4788b278687a8fd297cc0d0b86e5e25b40feefb2 Cr-Commit-Position: refs/heads/master@{#294452}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M components/password_manager/content/common/credential_manager_messages.h View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/ipc_fuzzer/ipclist/ipclist.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M tools/ipc_fuzzer/message_lib/all_messages.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Tom Sepez
Please review: @inferno - ipc_fuzzer/ changes @vabr - OWNERS stamp for password_manager/
6 years, 3 months ago (2014-09-08 18:49:37 UTC) #2
inferno
lgtm
6 years, 3 months ago (2014-09-08 19:14:01 UTC) #3
Tom Sepez
No owner respsonse .. Trying @isherman as alternate owner. This is a matter of getting ...
6 years, 3 months ago (2014-09-11 18:52:43 UTC) #5
Ilya Sherman
LGTM. I think that vabr@ is out on vacation this week.
6 years, 3 months ago (2014-09-11 19:01:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/551043004/1
6 years, 3 months ago (2014-09-11 19:05:07 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as ab0018c4deb507f38d2e537862d98f500735a28e
6 years, 3 months ago (2014-09-11 20:07:26 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4788b278687a8fd297cc0d0b86e5e25b40feefb2 Cr-Commit-Position: refs/heads/master@{#294452}
6 years, 3 months ago (2014-09-11 20:19:34 UTC) #10
vabr (Chromium)
6 years, 3 months ago (2014-09-15 14:54:27 UTC) #11
Message was sent while issue was closed.
On 2014/09/11 19:01:48, Ilya Sherman wrote:
> LGTM.  I think that vabr@ is out on vacation this week.

Indeed. Sorry for the delay, and thanks for the patch. password_manager change
LGTM.

Powered by Google App Engine
This is Rietveld 408576698