aw: Skip hardware onDraw when visible rect is empty

android_webview/browser/browser_view_renderer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/browser_view_renderer.h"
 
 #include "android_webview/browser/browser_view_renderer_client.h"
 #include "android_webview/browser/shared_renderer_state.h"
 #include "android_webview/common/aw_switches.h"
 #include "android_webview/public/browser/draw_gl.h"
@@ skipping 28 matching lines @@
 
 const int64 kFallbackTickTimeoutInMilliseconds = 100;
 
 // Used to calculate memory allocation. Determined experimentally.
 const size_t kMemoryMultiplier = 20;
 const size_t kBytesPerPixel = 4;
 const size_t kMemoryAllocationStep = 5 * 1024 * 1024;
 uint64 g_memory_override_in_bytes = 0u;
 
 // Used to calculate tile allocation. Determined experimentally.
-const size_t kTileMultiplier = 12;
+size_t kTileMultiplier = 12;
 const size_t kTileAllocationStep = 20;
 // This will be set by static function CalculateTileMemoryPolicy() during init.
 // See AwMainDelegate::BasicStartupComplete.
 size_t g_tile_area;
 
 class TracedValue : public base::debug::ConvertableToTraceFormat {
  public:
   explicit TracedValue(base::Value* value) : value_(value) {}
   static scoped_refptr<base::debug::ConvertableToTraceFormat> FromValue(
       base::Value* value) {
@@ skipping 30 matching lines @@
     g_memory_override_in_bytes *= 1024 * 1024;
   }
 
   if (!use_zero_copy) {
     // Use chrome's default tile size, which varies from 256 to 512.
     // Be conservative here and use the smallest tile size possible.
     g_tile_area = 256 * 256;
 
     // Also use a high tile limit since there are no file descriptor issues.
     GlobalTileManager::GetInstance()->SetTileLimit(1000);
+
+    kTileMultiplier *= 2;

[hush (inactive), 2014/09/09 00:06:02]

why do we do this? By the way, if you want to double this, kTileMultiplier is
not a constant any more, so you need to rename the variable.

[boliu, 2014/09/09 00:07:19]

Ahh crap, unrelated change that I didn't mean to upload.

[hush (inactive), 2014/09/09 00:09:45]

cool. Get rid of this and other parts lgtm.
You need a bug number for this to merge into m38.
On 2014/09/09 00:07:19, boliu wrote:

     return;
   }
 
   const char kDefaultTileSize[] = "384";
 
   if (!cl->HasSwitch(switches::kDefaultTileWidth))
     cl->AppendSwitchASCII(switches::kDefaultTileWidth, kDefaultTileSize);
 
   if (!cl->HasSwitch(switches::kDefaultTileHeight))
     cl->AppendSwitchASCII(switches::kDefaultTileHeight, kDefaultTileSize);
@@ skipping 147 matching lines @@
   }
 
   // Perform a software draw
   return OnDrawSoftware(java_canvas);
 }
 
 bool BrowserViewRenderer::OnDrawHardware(jobject java_canvas) {
   if (!compositor_)
     return false;
 
+  if (last_on_draw_global_visible_rect_.IsEmpty())
+    return client_->RequestDrawGL(java_canvas, false);
+
   if (!hardware_enabled_) {
     hardware_enabled_ = compositor_->InitializeHwDraw();
     if (hardware_enabled_) {
       tile_manager_key_ = GlobalTileManager::GetInstance()->PushBack(this);
       gpu::GLInProcessContext* share_context = compositor_->GetShareContext();
       DCHECK(share_context);
       shared_renderer_state_->SetSharedContext(share_context);
     }
   }
   if (!hardware_enabled_)
@@ skipping 538 matching lines @@
     base::StringAppendF(&str,
                         "surface width height: [%d %d] ",
                         draw_info->width,
                         draw_info->height);
     base::StringAppendF(&str, "is_layer: %d ", draw_info->is_layer);
   }
   return str;
 }
 
 }  // namespace android_webview