Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: cc/test/layer_test_common.cc

Issue 551013002: Use Custome ListContainer to Allocate SharedQuadState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DQAllo
Patch Set: use C++ range based loop Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/test/layer_test_common.cc
diff --git a/cc/test/layer_test_common.cc b/cc/test/layer_test_common.cc
index 287088725ac999d8da14b6bdd116b67f0e769bfd..9ca2aa293c99e03ff62809b1831d5c9a7393cdd2 100644
--- a/cc/test/layer_test_common.cc
+++ b/cc/test/layer_test_common.cc
@@ -40,7 +40,6 @@ void LayerTestCommon::VerifyQuadsExactlyCoverRect(const QuadList& quads,
const gfx::Rect& rect) {
Region remaining = rect;
- size_t i = 0;
for (QuadList::ConstIterator iter = quads.begin(); iter != quads.end();
++iter) {
const DrawQuad* quad = &*iter;
@@ -53,15 +52,13 @@ void LayerTestCommon::VerifyQuadsExactlyCoverRect(const QuadList& quads,
gfx::Rect quad_rect = gfx::ToEnclosingRect(quad_rectf);
- EXPECT_TRUE(rect.Contains(quad_rect)) << quad_string << i
+ EXPECT_TRUE(rect.Contains(quad_rect)) << quad_string << iter.index()
<< " rect: " << rect.ToString()
<< " quad: " << quad_rect.ToString();
EXPECT_TRUE(remaining.Contains(quad_rect))
- << quad_string << i << " remaining: " << remaining.ToString()
+ << quad_string << iter.index() << " remaining: " << remaining.ToString()
<< " quad: " << quad_rect.ToString();
remaining.Subtract(quad_rect);
-
- ++i;
}
EXPECT_TRUE(remaining.IsEmpty());

Powered by Google App Engine
This is Rietveld 408576698