Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(741)

Unified Diff: cc/quads/list_container_unittest.cc

Issue 551013002: Use Custome ListContainer to Allocate SharedQuadState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@DQAllo
Patch Set: use C++ range based loop Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/quads/list_container_unittest.cc
diff --git a/cc/quads/list_container_unittest.cc b/cc/quads/list_container_unittest.cc
index dd06877d22f53aac20eb1ec713da09d48477119c..8cd5e2e8409ff7783935ad344f869ca46c777eea 100644
--- a/cc/quads/list_container_unittest.cc
+++ b/cc/quads/list_container_unittest.cc
@@ -525,5 +525,39 @@ TEST(ListContainerTest,
}
}
+TEST(ListContainerTest,
+ SimpleIterationAndReverseIterationWithIndexSharedQuadState) {
+ ListContainer<SharedQuadState> list;
+ std::vector<SharedQuadState*> sqs_list;
+ size_t size = 10;
+ for (size_t i = 0; i < size; ++i) {
+ sqs_list.push_back(list.AllocateAndConstruct<SharedQuadState>());
+ }
+ EXPECT_EQ(size, list.size());
+
+ size_t i = 0;
+ std::vector<SharedQuadState*>::const_iterator sqs_iter = sqs_list.begin();
danakj 2014/10/02 15:32:48 drop teh vector iterator
weiliangc 2014/10/02 22:01:40 Done.
+ for (ListContainer<SharedQuadState>::Iterator iter = list.begin();
+ iter != list.end();
+ ++iter) {
+ EXPECT_EQ(*sqs_iter, &*iter);
danakj 2014/10/02 15:32:48 you already test this in other tests, just test th
weiliangc 2014/10/02 22:01:40 Done.
+ EXPECT_EQ(i, iter.index());
+ ++sqs_iter;
+ ++i;
+ }
+
+ i = 0;
+ std::vector<SharedQuadState*>::const_reverse_iterator reverse_sqs_iter =
+ sqs_list.rbegin();
+ for (ListContainer<SharedQuadState>::ReverseIterator iter = list.rbegin();
+ iter != list.rend();
+ ++iter) {
+ EXPECT_EQ(*reverse_sqs_iter, &*iter);
+ EXPECT_EQ(i, iter.index());
+ ++reverse_sqs_iter;
+ ++i;
+ }
+}
+
} // namespace
} // namespace cc

Powered by Google App Engine
This is Rietveld 408576698