Supervised user interstitial: Don't destroy WebContents that might still be in use

chrome/browser/supervised_user/supervised_user_interstitial.cc

Index: chrome/browser/supervised_user/supervised_user_interstitial.cc
diff --git a/chrome/browser/supervised_user/supervised_user_interstitial.cc b/chrome/browser/supervised_user/supervised_user_interstitial.cc
index a87ed8cd127aed77d99c486199fbe8bc3f400ed8..ec5dbdd7a6e7967aefc06d3dacfb564ac5eb2a0a 100644
--- a/chrome/browser/supervised_user/supervised_user_interstitial.cc
+++ b/chrome/browser/supervised_user/supervised_user_interstitial.cc
@@ -4,6 +4,7 @@
 
 #include "chrome/browser/supervised_user/supervised_user_interstitial.h"
 
+#include "base/memory/weak_ptr.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/string_number_conversions.h"
@@ -13,6 +14,8 @@
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/supervised_user/supervised_user_service.h"
 #include "chrome/browser/supervised_user/supervised_user_service_factory.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/generated_resources.h"
 #include "components/infobars/core/infobar.h"
@@ -23,6 +26,7 @@
 #include "content/public/browser/navigation_details.h"
 #include "content/public/browser/navigation_entry.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/browser/web_contents_user_data.h"
 #include "content/public/browser/web_ui.h"
 #include "grit/browser_resources.h"
 #include "ui/base/l10n/l10n_util.h"
@@ -31,6 +35,7 @@
 #include "ui/base/webui/web_ui_util.h"
 
 using content::BrowserThread;
+using content::WebContents;
 
 namespace {
 
@@ -45,11 +50,49 @@ std::string BuildAvatarImageUrl(const std::string& url, int size) {
   return result;
 }
 
-} // namespace
+class TabCloser : public content::WebContentsUserData<TabCloser> {
+ public:
+  static void CloseTab(WebContents* web_contents) {
+    CreateForWebContents(web_contents);
+  }
+
+ private:
+  friend class content::WebContentsUserData<TabCloser>;

[Bernhard Bauer, 2014/09/09 11:26:06]

Add a blank line afterwards?

[Marc Treib, 2014/09/09 11:51:25]

Done.

+  explicit TabCloser(WebContents* web_contents)
+      : web_contents_(web_contents), weak_ptr_factory_(this) {
+    BrowserThread::PostTask(
+        BrowserThread::UI,
+        FROM_HERE,
+        base::Bind(&TabCloser::CloseTabImpl, weak_ptr_factory_.GetWeakPtr()));
+  }
+  virtual ~TabCloser() {}
+
+  void CloseTabImpl() {
+    Browser* browser = chrome::FindBrowserWithWebContents(web_contents_);
+    DCHECK(browser);
+    TabStripModel* tab_strip = browser->tab_strip_model();
+    // Don't close the last tab in the window.

[Bernhard Bauer, 2014/09/09 11:26:06]

Nit: Can you move the comment into the else branch? Otherwise from a casual
glance it looks like this refers to the if-branch.

[Marc Treib, 2014/09/09 11:51:25]

Done.

+    if (tab_strip->count() > 1) {
+      int index = tab_strip->GetIndexOfWebContents(web_contents_);
+      DCHECK_NE(TabStripModel::kNoTab, index);
+      tab_strip->CloseWebContentsAt(
+          index, TabStripModel::CLOSE_CREATE_HISTORICAL_TAB);
+    } else {
+      web_contents_->RemoveUserData(UserDataKey());
+    }
+  }
+
+  WebContents* web_contents_;
+  base::WeakPtrFactory<TabCloser> weak_ptr_factory_;
+};
+
+}  // namespace
+
+DEFINE_WEB_CONTENTS_USER_DATA_KEY(TabCloser);

[Bernhard Bauer, 2014/09/09 11:26:06]

Can we put this into the anonymous namespace?

[Marc Treib, 2014/09/09 11:51:25]

No. In Clang's words:
../../chrome/browser/supervised_user/supervised_user_interstitial.cc:90:1:
error: cannot define or redeclare 'kLocatorKey' here because namespace '' does
not enclose namespace 'WebContentsUserData<(anonymous namespace)::TabCloser>'

(kinda makes sense, since it must be accessible from outside this
file/namespace)

 
 // static
 void SupervisedUserInterstitial::Show(
-    content::WebContents* web_contents,
+    WebContents* web_contents,
     const GURL& url,
     const base::Callback<void(bool)>& callback) {
   SupervisedUserInterstitial* interstitial =
@@ -62,7 +105,7 @@ void SupervisedUserInterstitial::Show(
 }
 
 SupervisedUserInterstitial::SupervisedUserInterstitial(
-    content::WebContents* web_contents,
+    WebContents* web_contents,
     const GURL& url,
     const base::Callback<void(bool)>& callback)
     : web_contents_(web_contents),
@@ -257,7 +300,7 @@ void SupervisedUserInterstitial::DispatchContinueRequest(
   // If there is no history entry to go back to, close the tab instead.
   int nav_entry_count = web_contents_->GetController().GetEntryCount();
   if (!continue_request && nav_entry_count == 0)
-    web_contents_->Close();
+    TabCloser::CloseTab(web_contents_);

[Bernhard Bauer, 2014/09/09 11:26:06]

Directly call TabCloser::CreateForContents()?

Alternatively, keep the method, but then why not check that there really isn't
already one attached? That way you can be more confident about that assumption.

[Marc Treib, 2014/09/09 11:51:25]

As you said, it doesn't really matter if there already is one; the new one will
just be ignored, which is fine. So I've removed the method and now call
CreateForWebContents directly.

 
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE, base::Bind(callback_, continue_request));