chrome/browser/supervised_user/supervised_user_browsertest.cc - Issue 550973002: Supervised user interstitial: Don't destroy WebContents that might still be in use

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_browsertest.cc

Issue 550973002: Supervised user interstitial: Don't destroy WebContents that might still be in use (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Android build Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/supervised_user/supervised_user_interstitial.cc » ('j') | chrome/browser/supervised_user/supervised_user_interstitial.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_browsertest.cc

diff --git a/chrome/browser/supervised_user/supervised_user_browsertest.cc b/chrome/browser/supervised_user/supervised_user_browsertest.cc

index bbe40e0e4965b74e2f5cf90981b17d681314dc00..10dfdcd5dd836eb18a38b6ae3e874b364efc6d8d 100644

--- a/chrome/browser/supervised_user/supervised_user_browsertest.cc

+++ b/chrome/browser/supervised_user/supervised_user_browsertest.cc

@@ -214,9 +214,12 @@ IN_PROC_BROWSER_TEST_F(SupervisedUserBlockModeTest, OpenBlockedURLInNewTab) {

// On pressing the "back" button, the new tab should be closed, and we should

// get back to the previous active tab.

MockTabStripModelObserver observer(tab_strip);

+ base::RunLoop run_loop;

EXPECT_CALL(observer,

- TabClosingAt(tab_strip, tab, tab_strip->active_index()));

+ TabClosingAt(tab_strip, tab, tab_strip->active_index()))

+ .WillOnce(testing::InvokeWithoutArgs(&run_loop, &base::RunLoop::Quit));

GoBack(tab);

+ run_loop.Run();

EXPECT_EQ(prev_tab, tab_strip->GetActiveWebContents());

}