Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 550943003: Warn on executing command on unsupported elements. (Closed)

Created:
6 years, 3 months ago by fukino
Modified:
6 years, 3 months ago
Reviewers:
yoshiki
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Warn on executing command on unsupported elements. Elements which don't have corresponding entries can be focused. (for example, when buttons are focused by <Tab>.) When they are focused, canExecute of commands are called and warnings are emitted in CommandUtil.getCommandEntry(). This CL warn more specific (really suspicious) case. That is, a command executed on an element which doesn't have corresponding entry. BUG=411790 TEST=manually tested Committed: https://crrev.com/712add9076ac2552ff32ce9be6d78289989ca7af Cr-Commit-Position: refs/heads/master@{#294125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -6 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager_commands.js View 4 chunks +16 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fukino
@yoshiki - Could you take a look? Thanks!
6 years, 3 months ago (2014-09-09 01:23:00 UTC) #2
yoshiki
lgtm
6 years, 3 months ago (2014-09-10 05:22:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fukino@chromium.org/550943003/1
6 years, 3 months ago (2014-09-10 05:36:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 283c0174942cf11dbb29ff2ab5c76db9a1e35e82
6 years, 3 months ago (2014-09-10 06:35:44 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 06:41:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/712add9076ac2552ff32ce9be6d78289989ca7af
Cr-Commit-Position: refs/heads/master@{#294125}

Powered by Google App Engine
This is Rietveld 408576698