Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 550933003: Update eme_player tests (Closed)

Created:
6 years, 3 months ago by jrummell
Modified:
6 years, 3 months ago
Reviewers:
xhwang, ddorwin
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove PROMISES_SUPPORTED check now that the promises code has landed. BUG=358271 TEST=EME browser tests pass Committed: https://crrev.com/acf5a0d3c6ba75e1991a48481be0a8918e8ffaf5 Cr-Commit-Position: refs/heads/master@{#293814}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -35 lines) Patch
M media/test/data/eme_player_js/clearkey_player.js View 1 chunk +3 lines, -7 lines 0 comments Download
M media/test/data/eme_player_js/globals.js View 1 chunk +0 lines, -3 lines 0 comments Download
M media/test/data/eme_player_js/player_utils.js View 2 chunks +9 lines, -17 lines 0 comments Download
M media/test/data/eme_player_js/widevine_player.js View 1 chunk +3 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jrummell
PTAL.
6 years, 3 months ago (2014-09-08 18:46:05 UTC) #2
ddorwin
Thanks. Please update the first line of the description to something like "Remove PROMISES_SUPPORTED check ...
6 years, 3 months ago (2014-09-08 18:48:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jrummell@chromium.org/550933003/1
6 years, 3 months ago (2014-09-08 19:09:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as ef746dc6bba498a34ebac10cc71ec7475458a14a
6 years, 3 months ago (2014-09-08 23:43:30 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:49:02 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/acf5a0d3c6ba75e1991a48481be0a8918e8ffaf5
Cr-Commit-Position: refs/heads/master@{#293814}

Powered by Google App Engine
This is Rietveld 408576698