Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 550913003: Rename experimental_accessibility to accessibility_private in histograms. (Closed)

Created:
6 years, 3 months ago by dmazzoni
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, asvitkine+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@focus_ring_1_refactor_global_coors
Project:
chromium
Visibility:
Public.

Description

Rename experimental_accessibility to accessibility_private in histograms. BUG=278540 NOPRESUBMIT=true R=isherman@chromium.org, rockot@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/dafe3f571c88a99097103e2bb31ec866b7534bdb

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M chrome/browser/accessibility/accessibility_extension_api.h View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 4 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 23 (7 generated)
dmazzoni
6 years, 3 months ago (2014-09-08 17:36:19 UTC) #2
Ken Rockot(use gerrit already)
[chrome/]extensions lgtm
6 years, 3 months ago (2014-09-08 17:38:13 UTC) #3
Ilya Sherman
lgtm
6 years, 3 months ago (2014-09-09 20:19:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/550913003/1
6 years, 3 months ago (2014-09-09 20:35:04 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9756)
6 years, 3 months ago (2014-09-09 21:37:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/550913003/20001
6 years, 3 months ago (2014-09-11 21:30:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10470)
6 years, 3 months ago (2014-09-11 22:33:11 UTC) #12
Ken Rockot(use gerrit already)
On 2014/09/11 22:33:11, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 3 months ago (2014-09-11 22:34:52 UTC) #13
dmazzoni
Will NOTRY bypass this or do I have to "git cl land"? Last time I ...
6 years, 3 months ago (2014-09-11 22:39:39 UTC) #14
Ken Rockot(use gerrit already)
I'm not really sure - I thought NOTRY still ran the presubmit job, but manual ...
6 years, 3 months ago (2014-09-11 22:41:37 UTC) #15
Ilya Sherman
I think you want NOPRESUBMIT
6 years, 3 months ago (2014-09-11 22:52:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/550913003/20001
6 years, 3 months ago (2014-09-12 17:40:47 UTC) #18
dmazzoni
On 2014/09/11 22:52:05, Ilya Sherman wrote: > I think you want NOPRESUBMIT I hope that ...
6 years, 3 months ago (2014-09-12 18:10:52 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/10667)
6 years, 3 months ago (2014-09-12 18:21:24 UTC) #21
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/dafe3f571c88a99097103e2bb31ec866b7534bdb Cr-Commit-Position: refs/heads/master@{#294685}
6 years, 3 months ago (2014-09-12 22:50:33 UTC) #22
dmazzoni
6 years, 3 months ago (2014-09-12 22:50:40 UTC) #23
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as dafe3f5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698