athena/home/app_list_view_delegate.cc - Issue 550883002: Fix SpeechUIModel lifetime issue in Chrome's AppListViewDelegate when switching profiles

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/home/app_list_view_delegate.cc

Issue 550883002: Fix SpeechUIModel lifetime issue in Chrome's AppListViewDelegate when switching profiles (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clear state for SetProfile(NULL) Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: athena/home/app_list_view_delegate.cc

diff --git a/athena/home/app_list_view_delegate.cc b/athena/home/app_list_view_delegate.cc

index d4a7f531d6ec4b329fe150bb845f65890fb5eb36..116f1de50015f80782a1ed5b67ac8e5f6c8c2a83 100644

--- a/athena/home/app_list_view_delegate.cc

+++ b/athena/home/app_list_view_delegate.cc

@@ -28,8 +28,7 @@ namespace athena {

AppListViewDelegate::AppListViewDelegate(AppModelBuilder* model_builder)

: model_(new app_list::AppListModel),

- speech_ui_(new app_list::SpeechUIModel(

- app_list::SPEECH_RECOGNITION_OFF)) {

+ speech_ui_(new app_list::SpeechUIModel) {

model_builder->PopulateApps(model_.get());

// TODO(mukai): get the text from the resources.

model_->search_box()->SetHintText(base::ASCIIToUTF16("Search"));

« no previous file with comments | « ash/shell/app_list.cc ('k') | chrome/browser/ui/app_list/app_list_view_delegate.cc » ('j') | no next file with comments »