Rename fileBrowserPrivate to fileManagerPrivate

Rename fileBrowserPrivate to fileManagerPrivate

fileBrowserPrivate was a misnomer as the term "file manager"
is used everywhere else (ex. src/ui/file_manager).

Note that fileBrowserHandler is not renamed because it's a
public API.

TEST=git grep -E -i file.?browser.?private || echo ok
BUG=411762
R=achuith@chromium.org, asvitkine@chromium.org, benwells@chromium.org, mtomasz@chromium.org, thestig@chromium.org, yoshiki@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/74e7c1c9210405bc5a3972b7530132fdaf33a7a9

[satorux1, 2014-09-08 08:02:00]

Patchset #1 (id:1) has been deleted

[satorux1, 2014-09-08 08:13:39]

satorux@chromium.org changed reviewers:
+ achuith@google.com, asvitkine@chromium.org, benwells@chromium.org,
mtomasz@chromium.org, thestig@chromium.org, yoshiki@chromium.org

[satorux1, 2014-09-08 08:13:41]

PTAL. Thought about splitting this into smaller patches but realized it was
simpler to do it in one patch, as this patch is essentially
s/file(.?)browser(.?)private/file\1manager\2private/g with case preserved, and
no manual changes required.

mtomasz:
  everything

yoshiki:
  ui/file_manager/
  chrome/browser/chromeos/drive/

benwells:
  chrome/browser/extensions/
  chrome/common/extensions/
  chrome/renderer/extensions/
  chrome/renderer/resources/extensions/
  extensions/
 
asvitkine:
  extensions/browser/extension_function_histogram_value.h
  tools/metrics/histograms/histograms.xml

achuith:
  chrome/test/ext_auto/auto_provider/manifest.json

thestig:
  chrome/renderer/resources/renderer_resources.grd

[mtomasz, 2014-09-08 08:51:35]

lgtm with a nit about comments.

https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h
(left):

https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h:17:
// Manages and registers the fileBrowserPrivate API with the extension system.
Not related to this CL, but since I'm here, I think we should rename this too.
APIs do not need services, especially not to register the API (as the comment
says). I think the main purpose of this class is just to have a long living
event router. Maybe we should merge it with the EventRouter class and rename
into FileManagerService. WDYT?

https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc
(right):

https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc:46: //  
extension with fileManagerPrivate permission (i.e. a file browser
These comments seem outdated now. There is no file browser extension which can
use this API.

[achuithb, 2014-09-08 09:47:06]

achuith@chromium.org changed reviewers:
+ achuith@chromium.org

[achuithb, 2014-09-08 09:47:07]

lgtm for ext_auto

[Alexei Svitkine (slow), 2014-09-08 14:53:29]

lgtm

[Lei Zhang, 2014-09-08 18:22:50]

non-{extensions,filemanager} changes in chrome/ LGTM

[benwells, 2014-09-08 23:40:28]

lgtm

[satorux1, 2014-09-09 01:41:29]

https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h
(left):

https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h:17:
// Manages and registers the fileBrowserPrivate API with the extension system.
On 2014/09/08 08:51:35, mtomasz wrote:
> Not related to this CL, but since I'm here, I think we should rename this too.
> APIs do not need services, especially not to register the API (as the comment
> says). I think the main purpose of this class is just to have a long living
> event router. Maybe we should merge it with the EventRouter class and rename
> into FileManagerService. WDYT?

SGTM. Let me do it in a separate patch. I want the patch to be just a bunch of
mechanical changes.

https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/...
File chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc
(right):

https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/...
chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc:46: //  
extension with fileManagerPrivate permission (i.e. a file browser
On 2014/09/08 08:51:35, mtomasz wrote:
> These comments seem outdated now. There is no file browser extension which can
> use this API.

Let me do it in a separate patch. I want the patch to be just a bunch of
mechanical changes.

[mtomasz, 2014-09-09 01:43:41]

On 2014/09/09 01:41:29, satorux1 wrote:
>
https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/...
> File
chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h
> (left):
> 
>
https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/...
> chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.h:17:
> // Manages and registers the fileBrowserPrivate API with the extension system.
> On 2014/09/08 08:51:35, mtomasz wrote:
> > Not related to this CL, but since I'm here, I think we should rename this
too.
> > APIs do not need services, especially not to register the API (as the
comment
> > says). I think the main purpose of this class is just to have a long living
> > event router. Maybe we should merge it with the EventRouter class and rename
> > into FileManagerService. WDYT?
> 
> SGTM. Let me do it in a separate patch. I want the patch to be just a bunch of
> mechanical changes.
> 
>
https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/...
> File chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc
> (right):
> 
>
https://codereview.chromium.org/550863003/diff/20001/chrome/browser/chromeos/...
> chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc:46: //  
> extension with fileManagerPrivate permission (i.e. a file browser
> On 2014/09/08 08:51:35, mtomasz wrote:
> > These comments seem outdated now. There is no file browser extension which
can
> > use this API.
> 
> Let me do it in a separate patch. I want the patch to be just a bunch of
> mechanical changes.

sgtm. lgtm.

[satorux1, 2014-09-09 04:19:30]

The CQ bit was checked by satorux@chromium.org

[commit-bot: I haz the power, 2014-09-09 04:29:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/satorux@chromium.org/550863003/60001

[yoshiki, 2014-09-09 05:26:03]

sorry for late. lgtm.

[commit-bot: I haz the power, 2014-09-09 08:22:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-09 08:22:42]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[satorux1, 2014-09-09 08:23:34]

The CQ bit was checked by satorux@chromium.org

[commit-bot: I haz the power, 2014-09-09 08:24:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/satorux@chromium.org/550863003/60001

[satorux1, 2014-09-09 08:30:46]

Looks CQ was not happy with warnings from
extensions/browser/extension_function_histogram_value.h though renaming the
existing enums should be safe. We should probably change the pre-submit check to
allow renames of enums.

I'll submit this with "git cl land" tomorrow.

[commit-bot: I haz the power, 2014-09-09 08:42:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-09 08:42:57]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-09-10 04:29:18]

Patchset 5 (id:??) landed as
https://crrev.com/74e7c1c9210405bc5a3972b7530132fdaf33a7a9
Cr-Commit-Position: refs/heads/master@{#294101}

[satorux1, 2014-09-10 04:30:51]

Committed patchset #5 (id:100001) manually as 74e7c1c (presubmit successful).