Chromium Code Reviews Chromium Code Reviews
Issue 55073003:
rebaseline_server: right-align "select/clear/toggle all tests" buttons with results table (Closed)
Base URL: http://skia.googlecode.com/svn/trunk/| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 | 2 |
| 3 <html ng-app="Loader" ng-controller="Loader.Controller"> | 3 <html ng-app="Loader" ng-controller="Loader.Controller"> |
| 4 | 4 |
| 5 <head> | 5 <head> |
| 6 <title ng-bind="windowTitle"></title> | 6 <title ng-bind="windowTitle"></title> |
| 7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js" ></script> | 7 <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.1.5/angular.js" ></script> |
| 8 <script src="loader.js"></script> | 8 <script src="loader.js"></script> |
| 9 <link rel="stylesheet" href="view.css"> | 9 <link rel="stylesheet" href="view.css"> |
| 10 </head> | 10 </head> |
| (...skipping 156 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 167 <li ng-repeat="setting in ['bug']"> | 167 <li ng-repeat="setting in ['bug']"> |
| 168 {{setting}} | 168 {{setting}} |
| 169 <input type="text" ng-model="submitAdvancedSettings[setting]"> | 169 <input type="text" ng-model="submitAdvancedSettings[setting]"> |
| 170 </li> | 170 </li> |
| 171 </ul> | 171 </ul> |
| 172 </div> | 172 </div> |
| 173 </div> | 173 </div> |
| 174 | 174 |
| 175 <p> | 175 <p> |
| 176 | 176 |
| 177 <div> | 177 <table border="0"><tr><td> <!-- table holding results header + results table --> |
|
epoger
2013/10/31 20:00:50
I know the "cool kids" use divs instead of tables
edisonn
2013/10/31 20:03:05
I would not care even if you have used NACL :D
| |
| 178 <div style="float:left"> | 178 <table border="0" width="100%"> <!-- results header --> |
| 179 Found {{filteredTestData.length}} matches; | 179 <tr> |
| 180 <span ng-hide="filteredTestData.length <= limitedTestData.length"> | 180 <td> |
| 181 displaying the first {{limitedTestData.length}} | 181 Found {{filteredTestData.length}} matches; |
| 182 </span> | 182 <span ng-hide="filteredTestData.length <= limitedTestData.length"> |
| 183 <span ng-hide="filteredTestData.length > limitedTestData.length"> | 183 displaying the first {{limitedTestData.length}} |
| 184 displaying them all | 184 </span> |
| 185 </span> | 185 <span ng-hide="filteredTestData.length > limitedTestData.length"> |
| 186 <br> | 186 displaying them all |
| 187 (click on the column header radio buttons to re-sort by that column) | 187 </span> |
| 188 </div> | 188 <br> |
| 189 <div style="float:right"> | 189 (click on the column header radio buttons to re-sort by that column) |
| 190 <div> | 190 </td> |
| 191 all tests shown: | 191 <td align="right"> |
| 192 <button ng-click="selectAllItems()"> | 192 <div> |
| 193 select | 193 all tests shown: |
| 194 </button> | 194 <button ng-click="selectAllItems()"> |
| 195 <button ng-click="clearAllItems()"> | 195 select |
| 196 clear | 196 </button> |
| 197 </button> | 197 <button ng-click="clearAllItems()"> |
| 198 <button ng-click="toggleAllItems()"> | 198 clear |
| 199 toggle | 199 </button> |
| 200 </button> | 200 <button ng-click="toggleAllItems()"> |
| 201 </div> | 201 toggle |
| 202 <div ng-repeat="otherTab in tabs"> | 202 </button> |
| 203 <button ng-click="moveSelectedItemsToTab(otherTab)" | 203 </div> |
| 204 ng-disabled="selectedItems.length == 0" | 204 <div ng-repeat="otherTab in tabs"> |
| 205 ng-hide="otherTab == viewingTab"> | 205 <button ng-click="moveSelectedItemsToTab(otherTab)" |
| 206 move {{selectedItems.length}} selected tests to {{otherTab}} tab | 206 ng-disabled="selectedItems.length == 0" |
| 207 </button> | 207 ng-hide="otherTab == viewingTab"> |
| 208 </div> | 208 move {{selectedItems.length}} selected tests to {{otherTab}} tab |
| 209 </div> | 209 </button> |
| 210 <div style="clear:both"> | 210 </div> |
| 211 </div> | 211 </td> |
| 212 </div> | 212 </tr> |
| 213 <br> | 213 </table> <!-- results header --> |
| 214 | 214 </td></tr><tr><td> |
| 215 <table border="1"> | 215 <table border="1"> <!-- results --> |
| 216 <tr> | 216 <tr> |
| 217 <!-- Most column headers are displayed in a common fashion... --> | 217 <!-- Most column headers are displayed in a common fashion... --> |
| 218 <th ng-repeat="categoryName in ['resultType', 'builder', 'test', 'conf ig']"> | 218 <th ng-repeat="categoryName in ['resultType', 'builder', 'test', 'conf ig']"> |
| 219 <input type="radio" | 219 <input type="radio" |
| 220 name="sortColumnRadio" | 220 name="sortColumnRadio" |
| 221 value="{{categoryName}}" | 221 value="{{categoryName}}" |
| 222 ng-checked="(sortColumn == categoryName)" | 222 ng-checked="(sortColumn == categoryName)" |
| 223 ng-click="sortResultsBy(categoryName)"> | 223 ng-click="sortResultsBy(categoryName)"> |
| 224 {{categoryName}} | 224 {{categoryName}} |
| 225 </th> | 225 </th> |
| (...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 287 <img width="{{imageSize}}" src="http://chromium-skia-gm.commondata storage.googleapis.com/gm/{{result.actualHashType}}/{{result.test}}/{{result.act ualHashDigest}}.png"/> | 287 <img width="{{imageSize}}" src="http://chromium-skia-gm.commondata storage.googleapis.com/gm/{{result.actualHashType}}/{{result.test}}/{{result.act ualHashDigest}}.png"/> |
| 288 </a> | 288 </a> |
| 289 </td> | 289 </td> |
| 290 <td> | 290 <td> |
| 291 <input type="checkbox" | 291 <input type="checkbox" |
| 292 name="rowSelect" | 292 name="rowSelect" |
| 293 value="{{result.index}}" | 293 value="{{result.index}}" |
| 294 ng-checked="isValueInArray(result.index, selectedItems)" | 294 ng-checked="isValueInArray(result.index, selectedItems)" |
| 295 ng-click="toggleValueInArray(result.index, selectedItems)"> | 295 ng-click="toggleValueInArray(result.index, selectedItems)"> |
| 296 </tr> | 296 </tr> |
| 297 </table> | 297 </table> <!-- results --> |
| 298 </td></tr></table> <!-- table holding results header + results table --> | |
| 299 | |
| 298 </div><!-- main display area of selected tab --> | 300 </div><!-- main display area of selected tab --> |
| 299 </div><!-- everything: hide until data is loaded --> | 301 </div><!-- everything: hide until data is loaded --> |
| 300 | 302 |
| 301 <!-- TODO(epoger): Can we get the base URLs (commondatastorage and | 303 <!-- TODO(epoger): Can we get the base URLs (commondatastorage and |
| 302 issues list) from | 304 issues list) from |
| 303 http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json | 305 http://skia.googlecode.com/svn/buildbot/site_config/global_variables.json |
| 304 ? I tried importing the | 306 ? I tried importing the |
| 305 http://skia.googlecode.com/svn/buildbot/skia_tools.js script and using | 307 http://skia.googlecode.com/svn/buildbot/skia_tools.js script and using |
| 306 that to do so, but I got Access-Control-Allow-Origin errors. | 308 that to do so, but I got Access-Control-Allow-Origin errors. |
| 307 --> | 309 --> |
| 308 | 310 |
| 309 </body> | 311 </body> |
| 310 </html> | 312 </html> |
| OLD | NEW |
