Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 550723002: Subzero: Use cvttss2si and similar instead of cvtss2si for fp->int casts. (Closed)

Created:
6 years, 3 months ago by Jim Stichnoth
Modified:
6 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Use cvttss2si and similar instead of cvtss2si for fp->int casts. This is the truncating cvt instruction instead of rounding. A few interesting floating point inputs are added to the cross tests. Also, the cross test error output is modified to be more clear. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b63cd88

Patch Set 1 #

Patch Set 2 : Add negative test inputs #

Total comments: 2

Patch Set 3 : Use truncating conversion instruction for fp to int conversions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -58 lines) Patch
M crosstest/test_cast_main.cpp View 1 6 chunks +41 lines, -33 lines 0 comments Download
M src/IceInstX8632.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/IceInstX8632.cpp View 3 chunks +12 lines, -5 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 chunk +6 lines, -1 line 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/fp.pnacl.ll View 12 chunks +12 lines, -12 lines 0 comments Download
M tests_lit/llvm2ice_tests/vector-cast.ll View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
6 years, 3 months ago (2014-09-06 21:27:33 UTC) #2
jvoung (off chromium)
LGTM https://codereview.chromium.org/550723002/diff/20001/src/IceTargetLoweringX8632.cpp File src/IceTargetLoweringX8632.cpp (right): https://codereview.chromium.org/550723002/diff/20001/src/IceTargetLoweringX8632.cpp#newcode2060 src/IceTargetLoweringX8632.cpp:2060: // TODO(stichnot): _cvt or _cvtt? seems like it ...
6 years, 3 months ago (2014-09-08 17:27:05 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/550723002/diff/20001/src/IceTargetLoweringX8632.cpp File src/IceTargetLoweringX8632.cpp (right): https://codereview.chromium.org/550723002/diff/20001/src/IceTargetLoweringX8632.cpp#newcode2060 src/IceTargetLoweringX8632.cpp:2060: // TODO(stichnot): _cvt or _cvtt? On 2014/09/08 17:27:05, jvoung ...
6 years, 3 months ago (2014-09-08 17:47:06 UTC) #4
Jim Stichnoth
6 years, 3 months ago (2014-09-08 17:47:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as b63cd88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698