Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 550663004: Port liblouis nacl test from upstream ChromeVox. (Closed)

Created:
6 years, 3 months ago by Peter Lundblad
Modified:
6 years, 3 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkcr
Project:
chromium
Visibility:
Public.

Description

Port liblouis nacl test from upstream ChromeVox. BUG=341951, 371692 R=dmazzoni@chromium.org Committed: https://crrev.com/e8c5c37f67d73f1581e45993dfef9345f2ec152f Cr-Commit-Position: refs/heads/master@{#294856}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -0 lines) Patch
M chrome/browser/resources/chromeos/chromevox/chromevox_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/braille_background.js View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/liblouis_nacl/liblouis_test.extjs View 1 chunk +130 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Peter Lundblad
6 years, 3 months ago (2014-09-15 15:44:55 UTC) #1
dmazzoni
lgtm
6 years, 3 months ago (2014-09-15 16:15:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/550663004/1
6 years, 3 months ago (2014-09-15 16:19:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as bdb41d88ffe9a354bc32e0ed743cff7a2b8d5964
6 years, 3 months ago (2014-09-15 18:48:30 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 19:03:36 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e8c5c37f67d73f1581e45993dfef9345f2ec152f
Cr-Commit-Position: refs/heads/master@{#294856}

Powered by Google App Engine
This is Rietveld 408576698