Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Unified Diff: athena/content/web_activity.h

Issue 550643002: [Athena] Hack to display favicons for web activities in overview mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: athena/content/web_activity.h
diff --git a/athena/content/web_activity.h b/athena/content/web_activity.h
index 6f8f9a96d45ecac700916431f617b220bd8e269d..2e3ed419cb71367374e86a49bdf93630568a5bbb 100644
--- a/athena/content/web_activity.h
+++ b/athena/content/web_activity.h
@@ -5,17 +5,25 @@
#ifndef ATHENA_CONTENT_PUBLIC_WEB_ACTIVITY_H_
#define ATHENA_CONTENT_PUBLIC_WEB_ACTIVITY_H_
+#include <vector>
+
#include "athena/activity/public/activity.h"
#include "athena/activity/public/activity_view_model.h"
#include "base/strings/string16.h"
#include "content/public/browser/web_contents_observer.h"
#include "ui/gfx/image/image_skia.h"
+class SkBitmap;
+
namespace content {
class BrowserContext;
class WebContents;
}
+namespace gfx {
+class Size;
+}
+
namespace views {
class WebView;
class WidgetDelegate;
@@ -49,6 +57,7 @@ class WebActivity : public Activity,
virtual void Init() OVERRIDE;
virtual SkColor GetRepresentativeColor() const OVERRIDE;
virtual base::string16 GetTitle() const OVERRIDE;
+ virtual gfx::ImageSkia GetIcon() const OVERRIDE;
virtual bool UsesFrame() const OVERRIDE;
virtual views::View* GetContentsView() OVERRIDE;
virtual void CreateOverviewModeImage() OVERRIDE;
@@ -57,6 +66,9 @@ class WebActivity : public Activity,
virtual void ResetContentsView() OVERRIDE;
// content::WebContentsObserver:
+ virtual void DidNavigateMainFrame(
+ const content::LoadCommittedDetails& details,
+ const content::FrameNavigateParams& params) OVERRIDE;
virtual void TitleWasSet(content::NavigationEntry* entry,
bool explicit_set) OVERRIDE;
virtual void DidUpdateFaviconURL(
@@ -64,6 +76,15 @@ class WebActivity : public Activity,
virtual void DidChangeThemeColor(SkColor theme_color) OVERRIDE;
private:
+ // Called when a favicon download initiated in DidUpdateFaviconURL()
+ // has completed.
+ void OnDidDownloadFavicon(
+ int id,
+ int http_status_code,
+ const GURL& url,
+ const std::vector<SkBitmap>& bitmaps,
+ const std::vector<gfx::Size>& original_bitmap_sizes);
+
// Make the content visible. This call should only be paired with
// MakeInvisible. Note: Upon object creation the content is visible.
void MakeVisible();
@@ -77,6 +98,7 @@ class WebActivity : public Activity,
content::BrowserContext* browser_context_;
const base::string16 title_;
+ gfx::ImageSkia icon_;
const GURL url_;
AthenaWebView* web_view_;
SkColor title_color_;

Powered by Google App Engine
This is Rietveld 408576698