Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4911)

Unified Diff: chrome/browser/download/download_target_info.h

Issue 55063002: Prefer opening PDF downloads in the browser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reorganize some code to address comments. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/download_target_info.h
diff --git a/chrome/browser/download/download_target_info.h b/chrome/browser/download/download_target_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..7069973f0646f6dfc84d9ccf8ae5392d38369f62
--- /dev/null
+++ b/chrome/browser/download/download_target_info.h
@@ -0,0 +1,33 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_TARGET_INFO_H_
+#define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_TARGET_INFO_H_
+
+#include "base/files/file_path.h"
+#include "content/public/browser/download_danger_type.h"
+#include "content/public/browser/download_item.h"
+
+struct DownloadTargetInfo {
+ DownloadTargetInfo();
+ ~DownloadTargetInfo();
+
+ base::FilePath target_path;
+ content::DownloadItem::TargetDisposition target_disposition;
+ content::DownloadDangerType danger_type;
+ base::FilePath intermediate_path;
Randy Smith (Not in Mondays) 2013/11/04 22:57:47 nit: There should probably be a sentence comment e
asanka 2013/11/05 21:31:39 Done.
+
+ // MIME type based on the file type of the download. This may be different
+ // from DownloadItem::GetMimeType() since the latter is based on the server
+ // response, and this one is based on the filename.
+ std::string mime_type;
+
+ // Whether the |target_path| would be handled safely by the browser if it were
+ // to be opened with a file:// URL. This can be used later to decide how file
+ // opens should be handled. The file is considered to be handled safely if the
+ // filetype is supported by the renderer or a sandboxed plug-in.
+ bool is_filetype_handled_securely;
+};
+
+#endif // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_TARGET_INFO_H_

Powered by Google App Engine
This is Rietveld 408576698