Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Unified Diff: components/password_manager/core/browser/password_form_manager.cc

Issue 550563002: [Password Generation] Allow generation when saved credentials aren't valid (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_form_manager.cc
diff --git a/components/password_manager/core/browser/password_form_manager.cc b/components/password_manager/core/browser/password_form_manager.cc
index 6033da65ac42cb799550c4cc21a7b2244838b3fb..7587ce8f7715dd04549e8c6c98fdf9c9c18cb370 100644
--- a/components/password_manager/core/browser/password_form_manager.cc
+++ b/components/password_manager/core/browser/password_form_manager.cc
@@ -441,7 +441,13 @@ void PasswordFormManager::OnRequestDone(
client_->AutofillResultsComputed();
+ // TODO(gcasto): Change this to check that best_matches_ is empty. This should
+ // be equivalent for the moment, but it's less clear and may not be
+ // equivalent in the future.
if (best_score <= 0) {
+ // If no saved forms can be used, then it isn't blacklisted and generation
+ // should be allowed.
+ driver_->AllowPasswordGenerationForForm(observed_form_);
return;
}
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698