Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: chrome/browser/android/bookmarks/bookmarks_bridge.h

Issue 550543003: Add Instrumental Test for BookmarksBridge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update DEPS Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_BOOKMARKS_BOOKMARKS_BRIDGE_H_ 5 #ifndef CHROME_BROWSER_ANDROID_BOOKMARKS_BOOKMARKS_BRIDGE_H_
6 #define CHROME_BROWSER_ANDROID_BOOKMARKS_BOOKMARKS_BRIDGE_H_ 6 #define CHROME_BROWSER_ANDROID_BOOKMARKS_BOOKMARKS_BRIDGE_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/jni_android.h" 10 #include "base/android/jni_android.h"
(...skipping 13 matching lines...) Expand all
24 class BookmarksBridge : public BaseBookmarkModelObserver, 24 class BookmarksBridge : public BaseBookmarkModelObserver,
25 public PartnerBookmarksShim::Observer { 25 public PartnerBookmarksShim::Observer {
26 public: 26 public:
27 BookmarksBridge(JNIEnv* env, jobject obj, jobject j_profile); 27 BookmarksBridge(JNIEnv* env, jobject obj, jobject j_profile);
28 void Destroy(JNIEnv*, jobject); 28 void Destroy(JNIEnv*, jobject);
29 29
30 static bool RegisterBookmarksBridge(JNIEnv* env); 30 static bool RegisterBookmarksBridge(JNIEnv* env);
31 31
32 bool IsDoingExtensiveChanges(JNIEnv* env, jobject obj); 32 bool IsDoingExtensiveChanges(JNIEnv* env, jobject obj);
33 33
34 void LoadEmptyPartnerBookmarkShimForTesting(JNIEnv* env, jobject obj);
35
34 base::android::ScopedJavaLocalRef<jobject> GetBookmarkByID( 36 base::android::ScopedJavaLocalRef<jobject> GetBookmarkByID(
35 JNIEnv* env, 37 JNIEnv* env,
36 jobject obj, 38 jobject obj,
37 jlong id, 39 jlong id,
38 jint type); 40 jint type);
39 41
40 void GetPermanentNodeIDs(JNIEnv* env, 42 void GetPermanentNodeIDs(JNIEnv* env,
41 jobject obj, 43 jobject obj,
42 jobject j_result_obj); 44 jobject j_result_obj);
43 45
(...skipping 11 matching lines...) Expand all
55 jobject obj, 57 jobject obj,
56 jobject j_result_obj); 58 jobject j_result_obj);
57 void GetAllFoldersWithDepths(JNIEnv* env, 59 void GetAllFoldersWithDepths(JNIEnv* env,
58 jobject obj, 60 jobject obj,
59 jobject j_folders_obj, 61 jobject j_folders_obj,
60 jobject j_depths_obj); 62 jobject j_depths_obj);
61 63
62 base::android::ScopedJavaLocalRef<jobject> GetMobileFolderId(JNIEnv* env, 64 base::android::ScopedJavaLocalRef<jobject> GetMobileFolderId(JNIEnv* env,
63 jobject obj); 65 jobject obj);
64 66
67 base::android::ScopedJavaLocalRef<jobject> GetOtherFolderId(JNIEnv* env,
68 jobject obj);
69
70 base::android::ScopedJavaLocalRef<jobject> GetDesktopFolderId(JNIEnv* env,
71 jobject obj);
72
65 void GetChildIDs(JNIEnv* env, 73 void GetChildIDs(JNIEnv* env,
66 jobject obj, 74 jobject obj,
67 jlong id, 75 jlong id,
68 jint type, 76 jint type,
69 jboolean get_folders, 77 jboolean get_folders,
70 jboolean get_bookmarks, 78 jboolean get_bookmarks,
71 jobject j_result_obj); 79 jobject j_result_obj);
72 80
73 void GetAllBookmarkIDsOrderedByCreationDate(JNIEnv* env, 81 void GetAllBookmarkIDsOrderedByCreationDate(JNIEnv* env,
74 jobject obj, 82 jobject obj,
(...skipping 18 matching lines...) Expand all
93 jobject j_folder_id_obj, 101 jobject j_folder_id_obj,
94 jobject j_callback_obj, 102 jobject j_callback_obj,
95 jobject j_result_obj); 103 jobject j_result_obj);
96 104
97 void GetCurrentFolderHierarchy(JNIEnv* env, 105 void GetCurrentFolderHierarchy(JNIEnv* env,
98 jobject obj, 106 jobject obj,
99 jobject j_folder_id_obj, 107 jobject j_folder_id_obj,
100 jobject j_callback_obj, 108 jobject j_callback_obj,
101 jobject j_result_obj); 109 jobject j_result_obj);
102 110
103 void DeleteBookmark(JNIEnv* env, 111 base::android::ScopedJavaLocalRef<jobject> AddFolder(JNIEnv* env,
104 jobject obj, 112 jobject obj,
105 jobject j_bookmark_id_obj); 113 jobject j_parent_id_obj,
114 jint index,
115 jstring j_title);
116
117 void DeleteBookmark(JNIEnv* env, jobject obj, jobject j_bookmark_id_obj);
106 118
107 void MoveBookmark(JNIEnv* env, 119 void MoveBookmark(JNIEnv* env,
108 jobject obj, 120 jobject obj,
109 jobject j_bookmark_id_obj, 121 jobject j_bookmark_id_obj,
110 jobject j_parent_id_obj, 122 jobject j_parent_id_obj,
111 jint index); 123 jint index);
112 124
125 base::android::ScopedJavaLocalRef<jobject> AddBookmark(
126 JNIEnv* env,
127 jobject obj,
128 jobject j_parent_id_obj,
129 jint index,
130 jstring j_title,
131 jstring j_url);
132
113 private: 133 private:
114 virtual ~BookmarksBridge(); 134 virtual ~BookmarksBridge();
115 135
116 base::android::ScopedJavaLocalRef<jobject> CreateJavaBookmark( 136 base::android::ScopedJavaLocalRef<jobject> CreateJavaBookmark(
117 const BookmarkNode* node); 137 const BookmarkNode* node);
118 void ExtractBookmarkNodeInformation( 138 void ExtractBookmarkNodeInformation(
119 const BookmarkNode* node, 139 const BookmarkNode* node,
120 jobject j_result_obj); 140 jobject j_result_obj);
121 const BookmarkNode* GetNodeByID(long node_id, int type); 141 const BookmarkNode* GetNodeByID(long node_id, int type);
122 const BookmarkNode* GetFolderWithFallback(long folder_id, int type); 142 const BookmarkNode* GetFolderWithFallback(long folder_id, int type);
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
171 ChromeBookmarkClient* client_; // weak 191 ChromeBookmarkClient* client_; // weak
172 192
173 // Information about the Partner bookmarks (must check for IsLoaded()). 193 // Information about the Partner bookmarks (must check for IsLoaded()).
174 // This is owned by profile. 194 // This is owned by profile.
175 PartnerBookmarksShim* partner_bookmarks_shim_; 195 PartnerBookmarksShim* partner_bookmarks_shim_;
176 196
177 DISALLOW_COPY_AND_ASSIGN(BookmarksBridge); 197 DISALLOW_COPY_AND_ASSIGN(BookmarksBridge);
178 }; 198 };
179 199
180 #endif // CHROME_BROWSER_ANDROID_BOOKMARKS_BOOKMARKS_BRIDGE_H_ 200 #endif // CHROME_BROWSER_ANDROID_BOOKMARKS_BOOKMARKS_BRIDGE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698