Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 550533002: libvpx: exclude NEON target on x86 for GN build (Closed)

Created:
6 years, 3 months ago by Alpha Left Google
Modified:
6 years, 3 months ago
Reviewers:
Tom Finegan
CC:
chromium-reviews, wwcv, jzern, fgalligan1
Visibility:
Public.

Description

libvpx: exclude NEON target on x86 for GN build Exclude NEON targets such that GN can build for all targets. TBR=tomfinegan Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291837

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M BUILD.gn View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Alpha Left Google
6 years, 3 months ago (2014-09-05 23:48:05 UTC) #2
Alpha Left Google
6 years, 3 months ago (2014-09-05 23:48:17 UTC) #3
Alpha Left Google
Committed patchset #1 (id:1) manually as r291837 (presubmit successful).
6 years, 3 months ago (2014-09-05 23:48:31 UTC) #4
chromium-reviews
Not sure what exactly is affected by this change but you should be able to ...
6 years, 3 months ago (2014-09-05 23:57:39 UTC) #5
Alpha Left Google
GN build for libvpx is not complete yet. It is expected to work only on ...
6 years, 3 months ago (2014-09-06 00:00:08 UTC) #6
Tom Finegan
6 years, 3 months ago (2014-09-09 20:00:34 UTC) #7
Message was sent while issue was closed.
On 2014/09/06 00:00:08, Alpha wrote:
> GN build for libvpx is not complete yet. It is expected to work only on x86.
But
> even on x86 it was building the arm files so I excluded those targets.

lgtm

Flu was trying to kill me-- catching up now, sorry for the delay!

Powered by Google App Engine
This is Rietveld 408576698