Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 550523002: Remove the old "SecureRandom" service, formerly used by get_random_bytes() (Closed)

Created:
6 years, 3 months ago by Mark Seaborn
Modified:
6 years, 3 months ago
Reviewers:
Roland McGrath
CC:
native-client-reviews_googlegroups.com
Project:
nacl
Visibility:
Public.

Description

Remove the old "SecureRandom" service, formerly used by get_random_bytes() "SecureRandom" is no longer used, since it was replaced by a new get_random_bytes() syscall. * Remove the RNG NaClDesc type. Remove DescWrapper's constructor for this descriptor type. * Remove the code that registers an RNG NaClDesc with the name service as "SecureRandom". Since this turns NaClDefaultNameServiceInit() into a no-op, remove that too. * Update a test that was checking SecureRandom as an example of a service. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3864 TEST= compile + run_nameservice_test Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=13715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -390 lines) Patch
M src/trusted/desc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/desc/build.scons View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/desc/desc.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/trusted/desc/nacl_desc_base.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/desc/nacl_desc_base.c View 3 chunks +0 lines, -3 lines 0 comments Download
D src/trusted/desc/nacl_desc_rng.h View 1 chunk +0 lines, -43 lines 0 comments Download
D src/trusted/desc/nacl_desc_rng.c View 1 chunk +0 lines, -203 lines 0 comments Download
M src/trusted/desc/nacl_desc_wrapper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/trusted/desc/nacl_desc_wrapper.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M src/trusted/service_runtime/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/service_runtime/build.scons View 1 chunk +0 lines, -1 line 0 comments Download
D src/trusted/service_runtime/name_service/default_name_service.h View 1 chunk +0 lines, -19 lines 0 comments Download
D src/trusted/service_runtime/name_service/default_name_service.c View 1 chunk +0 lines, -48 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr.c View 2 chunks +0 lines, -4 lines 0 comments Download
M src/trusted/service_runtime/service_runtime.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M tests/nameservice/nameservice_test.c View 2 chunks +10 lines, -45 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mark Seaborn
6 years, 3 months ago (2014-09-06 00:39:49 UTC) #2
Roland McGrath
lgtm
6 years, 3 months ago (2014-09-09 17:59:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/mseaborn@chromium.org/550523002/1
6 years, 3 months ago (2014-09-09 18:03:46 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 18:04:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 13715

Powered by Google App Engine
This is Rietveld 408576698