Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: chrome/browser/prerender/prerender_field_trial.cc

Issue 550453002: Avoid doing periodic prerender cleanup when there are no contents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/prerender/prerender_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_field_trial.cc
diff --git a/chrome/browser/prerender/prerender_field_trial.cc b/chrome/browser/prerender/prerender_field_trial.cc
index d89a31d77d3bf6a3f1651f67b7c298ec8eca226e..4dbac4be74a3efbd6bbffb2ba72993ce1cf76605 100644
--- a/chrome/browser/prerender/prerender_field_trial.cc
+++ b/chrome/browser/prerender/prerender_field_trial.cc
@@ -90,22 +90,27 @@ void SetupPrerenderFieldTrial() {
FieldTrial::Probability experiment_multi_prerender_probability;
FieldTrial::Probability experiment_15min_ttl_probability;
FieldTrial::Probability experiment_no_use_probability;
+ FieldTrial::Probability experiment_match_complete_probability;
chrome::VersionInfo::Channel channel = chrome::VersionInfo::GetChannel();
if (channel == chrome::VersionInfo::CHANNEL_STABLE ||
channel == chrome::VersionInfo::CHANNEL_BETA) {
// Use very conservatives and stable settings in beta and stable.
- const FieldTrial::Probability release_prerender_enabled_probability = 980;
+ const FieldTrial::Probability release_prerender_enabled_probability = 970;
const FieldTrial::Probability release_control_probability = 10;
const FieldTrial::Probability
release_experiment_multi_prerender_probability = 0;
const FieldTrial::Probability release_experiment_15min_ttl_probability = 10;
const FieldTrial::Probability release_experiment_no_use_probability = 0;
+ const FieldTrial::Probability
+ release_experiment_match_complete_probability = 10;
COMPILE_ASSERT(
- release_prerender_enabled_probability + release_control_probability +
+ release_prerender_enabled_probability +
+ release_control_probability +
release_experiment_multi_prerender_probability +
release_experiment_15min_ttl_probability +
- release_experiment_no_use_probability == divisor,
+ release_experiment_no_use_probability +
+ release_experiment_match_complete_probability == divisor,
release_experiment_probabilities_must_equal_divisor);
control_probability = release_control_probability;
@@ -113,19 +118,25 @@ void SetupPrerenderFieldTrial() {
release_experiment_multi_prerender_probability;
experiment_15min_ttl_probability = release_experiment_15min_ttl_probability;
experiment_no_use_probability = release_experiment_no_use_probability;
+ experiment_match_complete_probability =
+ release_experiment_match_complete_probability;
} else {
// In testing channels, use more experiments and a larger control group to
// improve quality of data.
- const FieldTrial::Probability dev_prerender_enabled_probability = 250;
- const FieldTrial::Probability dev_control_probability = 250;
+ const FieldTrial::Probability dev_prerender_enabled_probability = 200;
+ const FieldTrial::Probability dev_control_probability = 200;
+ const FieldTrial::Probability
+ dev_experiment_multi_prerender_probability = 200;
+ const FieldTrial::Probability dev_experiment_15min_ttl_probability = 100;
+ const FieldTrial::Probability dev_experiment_no_use_probability = 100;
const FieldTrial::Probability
- dev_experiment_multi_prerender_probability = 250;
- const FieldTrial::Probability dev_experiment_15min_ttl_probability = 125;
- const FieldTrial::Probability dev_experiment_no_use_probability = 125;
- COMPILE_ASSERT(dev_prerender_enabled_probability + dev_control_probability +
+ dev_experiment_match_complete_probability = 200;
+ COMPILE_ASSERT(dev_prerender_enabled_probability +
+ dev_control_probability +
dev_experiment_multi_prerender_probability +
dev_experiment_15min_ttl_probability +
- dev_experiment_no_use_probability == divisor,
+ dev_experiment_no_use_probability +
+ dev_experiment_match_complete_probability == divisor,
dev_experiment_probabilities_must_equal_divisor);
control_probability = dev_control_probability;
@@ -133,6 +144,8 @@ void SetupPrerenderFieldTrial() {
dev_experiment_multi_prerender_probability;
experiment_15min_ttl_probability = dev_experiment_15min_ttl_probability;
experiment_no_use_probability = dev_experiment_no_use_probability;
+ experiment_match_complete_probability =
+ dev_experiment_match_complete_probability;
}
int prerender_enabled_group = -1;
@@ -153,6 +166,9 @@ void SetupPrerenderFieldTrial() {
const int experiment_no_use_group =
trial->AppendGroup("PrerenderNoUse",
experiment_no_use_probability);
+ const int experiment_match_complete_group =
+ trial->AppendGroup("MatchComplete",
+ experiment_match_complete_probability);
const int trial_group = trial->group();
if (trial_group == prerender_enabled_group) {
@@ -170,6 +186,9 @@ void SetupPrerenderFieldTrial() {
} else if (trial_group == experiment_no_use_group) {
PrerenderManager::SetMode(
PrerenderManager::PRERENDER_MODE_EXPERIMENT_NO_USE_GROUP);
+ } else if (trial_group == experiment_match_complete_group) {
+ PrerenderManager::SetMode(
+ PrerenderManager::PRERENDER_MODE_EXPERIMENT_MATCH_COMPLETE_GROUP);
} else {
NOTREACHED();
}
« no previous file with comments | « chrome/browser/prerender/prerender_browsertest.cc ('k') | chrome/browser/prerender/prerender_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698