Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1515)

Issue 550443003: Reorder "action links" on chrome://extensions (Closed)

Created:
6 years, 3 months ago by Devlin
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou, Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Reorder "action links" on chrome://extensions Move the Options, Permissions, Visit website, Launch, and Reload links to be on the same line in the chrome://extensions page, directly below the description (so they are in the same place for all extensions in the list). Also reword "Visit website" to be either "Details" or "Developer website", depending on whether it will link to the developer's website or the chrome web store. Finally, tweak the css to give a bit more padding to the description and make the version text grey. ---------------------------- NOTE: The reviewed version of this patch is at https://codereview.chromium.org/540113002, but that one had the wrong Base URL (whoops). (TBRs are original reviewers) TBR=dbeam@chromium.org TBR=yoz@chromium.org BUG=410895 Committed: https://crrev.com/e9a62602e3eeefd44eafd1e69d0a3938ce4835ac Cr-Commit-Position: refs/heads/master@{#293739}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -30 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/extensions/extension_list.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/extensions/extensions.css View 4 chunks +16 lines, -9 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 2 chunks +15 lines, -17 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_url_handler.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/extensions/manifest_url_handler.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Yoyo Zhou
still LGTM
6 years, 3 months ago (2014-09-05 22:05:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/550443003/1
6 years, 3 months ago (2014-09-05 22:46:18 UTC) #4
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 04:48:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/550443003/1
6 years, 3 months ago (2014-09-08 16:15:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 64fad146812b9c1c4f8df48fbcce09ba0725c3e4
6 years, 3 months ago (2014-09-08 16:29:51 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:46:43 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9a62602e3eeefd44eafd1e69d0a3938ce4835ac
Cr-Commit-Position: refs/heads/master@{#293739}

Powered by Google App Engine
This is Rietveld 408576698