Issue 550423003: Ignore utime errors for until we restore old behavior for tar + libtar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 550423003: Ignore utime errors for until we restore old behavior for tar + libtar. (Closed)

Created:
6 years, 3 months ago by bradn

Modified:
6 years, 3 months ago

Reviewers:
binji

CC:
native-client-reviews_googlegroups.com, Sam Clegg

Base URL:
https://chromium.googlesource.com/external/naclports.git@master

Visibility:
Public.

Ignore utime errors for until we restore old behavior for tar + libtar. utime recently started returning EINVAL for mounts that don't implement it. This throws off libtar + tar, breaking most ports. BUG=https://code.google.com/p/chromium/issues/detail?id=414058 TEST=local TBR=binji@chromium.org Committed: https://chromium.googlesource.com/external/naclports/+/f32c0662cc4621583483db0cc90019a9b2afeb36

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -7 lines)			Patch
	M	ports/libtar/nacl.patch	View		7 chunks	+25 lines, -7 lines	0 comments	Download
	M	ports/tar/nacl.patch	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

bradn

Committed patchset #2 (id:20001) manually as f32c066 (presubmit successful).

6 years, 3 months ago (2014-09-13 22:12:10 UTC) #2

Message was sent while issue was closed.

lgtm