chrome/common/BUILD.gn - Issue 550423002: GN: Fix some breakage for os==chromeos build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/BUILD.gn

Issue 550423002: GN: Fix some breakage for os==chromeos build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address brett's brlapi comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/BUILD.gn

diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn

index 51c3908a0e8ddbf8c2623d8406d7eec79e6659cf..8d6e309eab6be24a5a2f3196f2c270de6fd7fc52 100644

--- a/chrome/common/BUILD.gn

+++ b/chrome/common/BUILD.gn

@@ -193,10 +193,6 @@ static_library("common") {

sources += [ "local_discovery/local_discovery_messages.h" ]

}

- if (is_chromeos) {

- sources -= [ "chrome_version_info_linux.cc" ]

- }

if (is_mac) {

sources -= [

"chrome_version_info_posix.cc",

« no previous file with comments | « chrome/chrome_common.gypi ('k') | chromeos/BUILD.gn » ('j') | no next file with comments »