Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 550423002: GN: Fix some breakage for os==chromeos build (Closed)

Created:
6 years, 3 months ago by Chris Masone
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN: Fix some breakage for os==chromeos build build/config/linux/BUILD.gn: * Usage of generate_library_loader for libbrlapi was incorrect; there * was nothing provided for "functions". This is now an empty list. chrome/chrome_common.gypi chrome/common/BUILD.gn * Reference to a removed file, chrome_version_info_linux.cc chromeos/BUILD.gn components/pairing/BUILD.gn * Usage of removed proto_{in,out}_dir in proto_library rules. content/gpu/BUILD.gn * Typo in reference to third_party/libva:libva_config ui/views/BUILD.gn * Attempt to filter source files out of * gypi_values.views_unittests_sources by subdirectory path. Fortunately * that variable already doesn't include the files that were supposed * to be filtered out, so the rule is simply removed. BUG=388412 TEST=Create a target that builds //mojo/public, build with os==chromeos R=brettw@chromium.org Committed: https://crrev.com/418e04caaf5701fac99ae766ab60f2e65279fccd Cr-Commit-Position: refs/heads/master@{#293964}

Patch Set 1 #

Total comments: 1

Patch Set 2 : address brett's brlapi comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M build/config/linux/BUILD.gn View 1 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M chromeos/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/pairing/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M content/gpu/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 15 (4 generated)
Chris Masone
6 years, 3 months ago (2014-09-08 21:39:40 UTC) #1
brettw
lgtm https://codereview.chromium.org/550423002/diff/1/build/config/linux/BUILD.gn File build/config/linux/BUILD.gn (right): https://codereview.chromium.org/550423002/diff/1/build/config/linux/BUILD.gn#newcode146 build/config/linux/BUILD.gn:146: functions = [] I think you actually need ...
6 years, 3 months ago (2014-09-08 22:16:07 UTC) #2
Chris Masone
Guys, can you sign off on whichever BUILD.gn files are under your purview?
6 years, 3 months ago (2014-09-09 00:53:52 UTC) #4
Zachary Kuznia
components/pairing/BUILD.gn LGTM
6 years, 3 months ago (2014-09-09 01:04:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmasone@chromium.org/550423002/20001
6 years, 3 months ago (2014-09-09 03:48:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9575)
6 years, 3 months ago (2014-09-09 08:13:17 UTC) #9
sky
LGTM
6 years, 3 months ago (2014-09-09 15:43:53 UTC) #10
stevenjb
src/chromeos owner lgtm
6 years, 3 months ago (2014-09-09 17:43:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cmasone@chromium.org/550423002/20001
6 years, 3 months ago (2014-09-09 17:46:17 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 9e8e0046a65bb9df7b3d9f762dee64adbe916cc6
6 years, 3 months ago (2014-09-09 17:53:49 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:11 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/418e04caaf5701fac99ae766ab60f2e65279fccd
Cr-Commit-Position: refs/heads/master@{#293964}

Powered by Google App Engine
This is Rietveld 408576698