Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: extensions/browser/api/app_window/app_window_api.cc

Issue 550413002: Revert "Add AppWindow.setVisibleOnAllWorkspaces." (https://codereview.chromium.org/469993003) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/app_window/app_window_api.cc
diff --git a/extensions/browser/api/app_window/app_window_api.cc b/extensions/browser/api/app_window/app_window_api.cc
index 2a80004ecdf69ee26734dc5afa6eef3032d220db..b6ecd5afb36bf282625b899f89af49205c2d430c 100644
--- a/extensions/browser/api/app_window/app_window_api.cc
+++ b/extensions/browser/api/app_window/app_window_api.cc
@@ -56,8 +56,6 @@ const char kAlphaEnabledMissingPermission[] =
"The alphaEnabled option requires app.window.alpha permission.";
const char kAlphaEnabledNeedsFrameNone[] =
"The alphaEnabled option can only be used with \"frame: 'none'\".";
-const char kVisibleOnAllWorkspacesWrongChannel[] =
- "The visibleOnAllWorkspaces option requires dev channel or newer.";
} // namespace app_window_constants
const char kNoneFrameOption[] = "none";
@@ -261,15 +259,6 @@ bool AppWindowCreateFunction::RunAsync() {
if (options->focused.get())
create_params.focused = *options->focused.get();
- if (options->visible_on_all_workspaces.get()) {
- if (AppsClient::Get()->IsCurrentChannelOlderThanDev()) {
- error_ = app_window_constants::kVisibleOnAllWorkspacesWrongChannel;
- return false;
- }
- create_params.visible_on_all_workspaces =
- *options->visible_on_all_workspaces.get();
- }
-
if (options->type != app_window::WINDOW_TYPE_PANEL) {
switch (options->state) {
case app_window::STATE_NONE:

Powered by Google App Engine
This is Rietveld 408576698