chrome/test/data/extensions/platform_apps/window_api/test.js - Issue 550413002: Revert "Add AppWindow.setVisibleOnAllWorkspaces." (https://codereview.chromium.org/469993003)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/platform_apps/window_api/test.js

Issue 550413002: Revert "Add AppWindow.setVisibleOnAllWorkspaces." (https://codereview.chromium.org/469993003) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/api/app_current_window_internal.idl ('k') | chrome/test/data/extensions/platform_apps/windows_api_visible_on_all_workspaces/in_stable/background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/platform_apps/window_api/test.js

diff --git a/chrome/test/data/extensions/platform_apps/window_api/test.js b/chrome/test/data/extensions/platform_apps/window_api/test.js

index 14396a3dfbfbd83855a38b401e53390c9da3c709..ebcc4447339240d001de0cdd34ad7bbbda55528d 100644

--- a/chrome/test/data/extensions/platform_apps/window_api/test.js

+++ b/chrome/test/data/extensions/platform_apps/window_api/test.js

@@ -1352,21 +1352,6 @@ function testFrameColors() {

]);

}

-function testVisibleOnAllWorkspaces() {

- chrome.test.runTests([

- function setAndUnsetVisibleOnAllWorkspaces() {

- chrome.app.window.create('test.html', {

- visibleOnAllWorkspaces: true

- }, callbackPass(function(win) {

- win.setVisibleOnAllWorkspaces(false);

- win.setVisibleOnAllWorkspaces(true);

- chrome.test.sendMessage(

- 'WaitForRoundTrip', callbackPass(function(reply) {}));

- }));

- },

- ]);

chrome.app.runtime.onLaunched.addListener(function() {

chrome.test.sendMessage('Launched', function(reply) {

window[reply]();