chrome/browser/ui/views/apps/chrome_native_app_window_views.cc - Issue 550413002: Revert "Add AppWindow.setVisibleOnAllWorkspaces." (https://codereview.chromium.org/469993003)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

Issue 550413002: Revert "Add AppWindow.setVisibleOnAllWorkspaces." (https://codereview.chromium.org/469993003) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

diff --git a/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc b/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

index 44b62d1a0cde178f4ecd2afd521d43dd09f044a9..18765b787549a89f94b9773205bb0a61688f8397 100644

--- a/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

+++ b/chrome/browser/ui/views/apps/chrome_native_app_window_views.cc

@@ -215,8 +215,6 @@ void ChromeNativeAppWindowViews::InitializeDefaultWindow(

if (create_params.alpha_enabled)

init_params.opacity = views::Widget::InitParams::TRANSLUCENT_WINDOW;

init_params.keep_on_top = create_params.always_on_top;

- init_params.visible_on_all_workspaces =

- create_params.visible_on_all_workspaces;

#if defined(OS_LINUX) && !defined(OS_CHROMEOS)

// Set up a custom WM_CLASS for app windows. This allows task switchers in

« no previous file with comments | « chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm ('k') | chrome/common/extensions/api/_api_features.json » ('j') | no next file with comments »