Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4757)

Unified Diff: chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc

Issue 550413002: Revert "Add AppWindow.setVisibleOnAllWorkspaces." (https://codereview.chromium.org/469993003) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc
diff --git a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc
index 18554f7cba492090c8b714d9b1eeedcdecc52d5c..28ffe4e39261170bc1f1d533c1412d5c91451e1b 100644
--- a/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc
+++ b/chrome/browser/extensions/api/app_current_window_internal/app_current_window_internal_api.cc
@@ -27,8 +27,6 @@ namespace SetIcon = app_current_window_internal::SetIcon;
namespace SetBadgeIcon = app_current_window_internal::SetBadgeIcon;
namespace SetShape = app_current_window_internal::SetShape;
namespace SetAlwaysOnTop = app_current_window_internal::SetAlwaysOnTop;
-namespace SetVisibleOnAllWorkspaces =
- app_current_window_internal::SetVisibleOnAllWorkspaces;
using app_current_window_internal::Bounds;
using app_current_window_internal::Region;
@@ -399,18 +397,4 @@ bool AppCurrentWindowInternalSetAlwaysOnTopFunction::RunWithWindow(
return true;
}
-bool AppCurrentWindowInternalSetVisibleOnAllWorkspacesFunction::RunWithWindow(
- AppWindow* window) {
- if (GetCurrentChannel() > chrome::VersionInfo::CHANNEL_DEV) {
- error_ = kDevChannelOnly;
- return false;
- }
-
- scoped_ptr<SetVisibleOnAllWorkspaces::Params> params(
- SetVisibleOnAllWorkspaces::Params::Create(*args_));
- CHECK(params.get());
- window->GetBaseWindow()->SetVisibleOnAllWorkspaces(params->always_visible);
- return true;
-}
-
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698