Revert "Add AppWindow.setVisibleOnAllWorkspaces." (https://codereview.chromium.org/469993003)

chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/cocoa/apps/native_app_window_cocoa.h"
 
 #include "apps/app_shim/extension_app_shim_handler_mac.h"
 #include "base/command_line.h"
 #include "base/mac/foundation_util.h"
 #include "base/mac/mac_util.h"
@@ skipping 42 matching lines @@
 
 void SetFullScreenCollectionBehavior(NSWindow* window, bool allow_fullscreen) {
   NSWindowCollectionBehavior behavior = [window collectionBehavior];
   if (allow_fullscreen)
     behavior |= NSWindowCollectionBehaviorFullScreenPrimary;
   else
     behavior &= ~NSWindowCollectionBehaviorFullScreenPrimary;
   [window setCollectionBehavior:behavior];
 }
 
-void SetWorkspacesCollectionBehavior(NSWindow* window, bool always_visible) {
-  NSWindowCollectionBehavior behavior = [window collectionBehavior];
-  if (always_visible)
-    behavior |= NSWindowCollectionBehaviorCanJoinAllSpaces;
-  else
-    behavior &= ~NSWindowCollectionBehaviorCanJoinAllSpaces;
-  [window setCollectionBehavior:behavior];
-}
-
 void InitCollectionBehavior(NSWindow* window) {
   // Since always-on-top windows have a higher window level
   // than NSNormalWindowLevel, they will default to
   // NSWindowCollectionBehaviorTransient. Set the value
   // explicitly here to match normal windows.
   NSWindowCollectionBehavior behavior = [window collectionBehavior];
   behavior |= NSWindowCollectionBehaviorManaged;
   [window setCollectionBehavior:behavior];
 }
 
@@ skipping 299 matching lines @@
   }
 
   if (base::mac::IsOSSnowLeopard() &&
       [window respondsToSelector:@selector(setBottomCornerRounded:)])
     [window setBottomCornerRounded:NO];
 
   if (params.always_on_top)
     [window setLevel:AlwaysOnTopWindowLevel()];
   InitCollectionBehavior(window);
 
-  SetWorkspacesCollectionBehavior(window, params.visible_on_all_workspaces);
-
   window_controller_.reset(
       [[NativeAppWindowController alloc] initWithWindow:window.release()]);
 
   NSView* view = WebContents()->GetNativeView();
   [view setAutoresizingMask:NSViewWidthSizable | NSViewHeightSizable];
 
   InstallView();
 
   [[window_controller_ window] setDelegate:window_controller_];
   [window_controller_ setAppWindow:this];
@@ skipping 568 matching lines @@
     [[window() standardWindowButton:NSWindowZoomButton]
         setEnabled:shows_fullscreen_controls_];
   }
 }
 
 void NativeAppWindowCocoa::SetAlwaysOnTop(bool always_on_top) {
   [window() setLevel:(always_on_top ? AlwaysOnTopWindowLevel() :
                                       NSNormalWindowLevel)];
 }
 
-void NativeAppWindowCocoa::SetVisibleOnAllWorkspaces(bool always_visible) {
-  SetWorkspacesCollectionBehavior(window(), always_visible);
-}
-
 NativeAppWindowCocoa::~NativeAppWindowCocoa() {
 }
 
 ShellNSWindow* NativeAppWindowCocoa::window() const {
   NSWindow* window = [window_controller_ window];
   CHECK(!window || [window isKindOfClass:[ShellNSWindow class]]);
   return static_cast<ShellNSWindow*>(window);
 }
 
 content::WebContents* NativeAppWindowCocoa::WebContents() const {
   return app_window_->web_contents();
 }
 
 void NativeAppWindowCocoa::UpdateRestoredBounds() {
   if (IsRestored(*this))
     restored_bounds_ = [window() frame];
 }
 
 void NativeAppWindowCocoa::HideWithoutMarkingHidden() {
   [window() orderOut:window_controller_];
 }