Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 550403003: Move declarative api files to extensions/browser/api/declarative. (Closed)

Created:
6 years, 3 months ago by wjmaclean
Modified:
6 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, tfarina, jam, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, James Su, Fady Samuel, Xi Han, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move declarative api files to extensions/browser/api/declarative. This cl also includes some small changes to remove chrome/extensions dependencies in these files, e.g. it gets IsIncognitoEnabled() from ExtensionPrefs() instead of util::IsIncognitoEnabled(). BUG=352293 Committed: https://crrev.com/97b60ee352ca47814774ffe9a4bebfc6d44b3e05 Cr-Commit-Position: refs/heads/master@{#294186}

Patch Set 1 #

Patch Set 2 : Fix tests, update BUILD.gn files. #

Patch Set 3 : Rebase to master@293939 (in order to run try-jobs) #

Patch Set 4 : Refactor ExtensionService, RulesRegistryService, fix browser_tests. #

Patch Set 5 : Rebase to master@294002 #

Patch Set 6 : Compile fix. #

Patch Set 7 : Remove IsIncognitoEnabled() changes. #

Patch Set 8 : Rebase to master@294157 #

Patch Set 9 : Fix browser tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -2742 lines) Patch
M chrome/browser/extensions/api/chrome_extensions_api_client.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/chrome_extensions_api_client.cc View 1 2 3 4 5 6 7 2 chunks +9 lines, -0 lines 0 comments Download
D chrome/browser/extensions/api/declarative/declarative_api.h View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/extensions/api/declarative/declarative_api.cc View 1 chunk +0 lines, -162 lines 0 comments Download
D chrome/browser/extensions/api/declarative/declarative_rule.h View 1 chunk +0 lines, -517 lines 0 comments Download
D chrome/browser/extensions/api/declarative/declarative_rule_unittest.cc View 1 1 chunk +0 lines, -442 lines 0 comments Download
D chrome/browser/extensions/api/declarative/rules_cache_delegate.h View 1 chunk +0 lines, -112 lines 0 comments Download
D chrome/browser/extensions/api/declarative/rules_cache_delegate.cc View 1 chunk +0 lines, -232 lines 0 comments Download
D chrome/browser/extensions/api/declarative/rules_registry.h View 1 chunk +0 lines, -296 lines 0 comments Download
D chrome/browser/extensions/api/declarative/rules_registry.cc View 1 chunk +0 lines, -380 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.h View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service.cc View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_service_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/declarative/test_rules_registry.h View 1 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/extensions/api/declarative/test_rules_registry.cc View 1 1 chunk +0 lines, -55 lines 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_action.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_condition.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_content/content_rules_registry.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_action.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute.h View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry.h View 1 2 3 4 5 6 7 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 6 7 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/api/events.json View 1 chunk +0 lines, -335 lines 0 comments Download
M chrome/common/extensions/api/schemas.gypi View 1 2 3 4 5 6 7 1 chunk +0 lines, -1 line 0 comments Download
M extensions/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +10 lines, -0 lines 0 comments Download
A + extensions/browser/api/declarative/declarative_api.h View 1 2 3 4 5 2 chunks +6 lines, -6 lines 0 comments Download
A + extensions/browser/api/declarative/declarative_api.cc View 1 2 3 4 5 6 7 8 2 chunks +14 lines, -11 lines 0 comments Download
A + extensions/browser/api/declarative/declarative_rule.h View 4 chunks +5 lines, -5 lines 0 comments Download
A + extensions/browser/api/declarative/declarative_rule_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
A + extensions/browser/api/declarative/rules_cache_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/browser/api/declarative/rules_cache_delegate.cc View 1 2 3 4 5 6 3 chunks +12 lines, -14 lines 0 comments Download
A + extensions/browser/api/declarative/rules_registry.h View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
A + extensions/browser/api/declarative/rules_registry.cc View 2 chunks +2 lines, -5 lines 0 comments Download
A + extensions/browser/api/declarative/test_rules_registry.h View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
A + extensions/browser/api/declarative/test_rules_registry.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/extensions_api_client.h View 1 2 3 4 5 6 7 2 chunks +8 lines, -0 lines 0 comments Download
M extensions/browser/api/extensions_api_client.cc View 1 2 3 4 5 6 7 1 chunk +7 lines, -0 lines 0 comments Download
A + extensions/common/api/events.json View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/api/schemas.gypi View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M extensions/extensions.gyp View 1 2 3 4 5 6 7 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
wjmaclean
rockot@ - I think this is ready (or at least very close). Would you mind ...
6 years, 3 months ago (2014-09-10 14:23:03 UTC) #4
Ken Rockot(use gerrit already)
I've got nothing to add, lgtm!
6 years, 3 months ago (2014-09-10 16:30:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/550403003/170046
6 years, 3 months ago (2014-09-10 16:34:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (None)
6 years, 3 months ago (2014-09-10 17:22:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/550403003/170046
6 years, 3 months ago (2014-09-10 17:30:15 UTC) #11
commit-bot: I haz the power
Committed patchset #9 (id:170046) as 757077deb9e438fc3ba401a991053df2a21c8f6a
6 years, 3 months ago (2014-09-10 17:33:36 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 17:42:07 UTC) #13
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/97b60ee352ca47814774ffe9a4bebfc6d44b3e05
Cr-Commit-Position: refs/heads/master@{#294186}

Powered by Google App Engine
This is Rietveld 408576698