Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 550403002: In AndroidBrowserBackend.Start(), make sure the application is stoped when setting the relaxsslchec… (Closed)

Created:
6 years, 3 months ago by wuhu
Modified:
6 years, 3 months ago
Reviewers:
nednguyen, tonyg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set the relaxsslcheck flag before stopping the browser. BUG= Committed: https://crrev.com/3910fcabde0fb21898a0bfb28fdcec7c302c6321 Cr-Commit-Position: refs/heads/master@{#293872}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Set relaxsslcheck before stopping browser. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 1 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (3 generated)
wuhu
Please review when you get a chance. Thanks
6 years, 3 months ago (2014-09-08 21:16:26 UTC) #2
nednguyen
The actual fix should be removing Start method of browser. possible_browser.Create() method returns a _running_ ...
6 years, 3 months ago (2014-09-08 21:31:27 UTC) #3
tony
(wrong tony)
6 years, 3 months ago (2014-09-08 21:34:49 UTC) #5
tonyg
https://codereview.chromium.org/550403002/diff/1/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py File tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py (right): https://codereview.chromium.org/550403002/diff/1/tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py#newcode201 tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py:201: self._adb.device().ForceStop(self._backend_settings.package) We already do this here. Can we just ...
6 years, 3 months ago (2014-09-08 22:27:55 UTC) #6
wuhu
Moved relaxsslcheck to the constructor. Thanks.
6 years, 3 months ago (2014-09-08 23:36:12 UTC) #7
tonyg
lgtm
6 years, 3 months ago (2014-09-08 23:40:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wuhu@google.com/550403002/20001
6 years, 3 months ago (2014-09-08 23:43:57 UTC) #10
nednguyen
lgtm since tony is happy
6 years, 3 months ago (2014-09-08 23:44:23 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as f4e8aedd868d18f7f0fd8dec6449bd737b08c864
6 years, 3 months ago (2014-09-09 06:30:19 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:51:16 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3910fcabde0fb21898a0bfb28fdcec7c302c6321
Cr-Commit-Position: refs/heads/master@{#293872}

Powered by Google App Engine
This is Rietveld 408576698