Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: remoting/protocol/channel_factory.h

Issue 550383002: Cleanup ChannelFactory interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « remoting/protocol/channel_dispatcher_base.cc ('k') | remoting/protocol/channel_multiplexer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef REMOTING_PROTOCOL_CHANNEL_FACTORY_H_ 5 #ifndef REMOTING_PROTOCOL_CHANNEL_FACTORY_H_
6 #define REMOTING_PROTOCOL_CHANNEL_FACTORY_H_ 6 #define REMOTING_PROTOCOL_CHANNEL_FACTORY_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/threading/non_thread_safe.h" 10 #include "base/threading/non_thread_safe.h"
11 11
12 namespace net { 12 namespace net {
13 class Socket; 13 class Socket;
14 class StreamSocket; 14 class StreamSocket;
15 } // namespace net 15 } // namespace net
16 16
17 namespace remoting { 17 namespace remoting {
18 namespace protocol { 18 namespace protocol {
19 19
20 class ChannelFactory : public base::NonThreadSafe { 20 class ChannelFactory : public base::NonThreadSafe {
21 public: 21 public:
22 // TODO(sergeyu): Specify connection error code when channel 22 // TODO(sergeyu): Specify connection error code when channel
23 // connection fails. 23 // connection fails.
24 typedef base::Callback<void(scoped_ptr<net::StreamSocket>)> 24 typedef base::Callback<void(scoped_ptr<net::StreamSocket>)>
25 StreamChannelCallback; 25 ChannelCreatedCallback;
26 typedef base::Callback<void(scoped_ptr<net::Socket>)>
27 DatagramChannelCallback;
28 26
29 ChannelFactory() {} 27 ChannelFactory() {}
30 28
31 // Creates new channels for this connection. The specified callback is called 29 // Creates new channels for this connection. The specified callback is called
32 // when then new channel is created and connected. The callback is called with 30 // when then new channel is created and connected. The callback is called with
33 // NULL if connection failed for any reason. Callback may be called 31 // NULL if connection failed for any reason. Callback may be called
34 // synchronously, before the call returns. All channels must be destroyed 32 // synchronously, before the call returns. All channels must be destroyed
35 // before the factory is destroyed and CancelChannelCreation() must be called 33 // before the factory is destroyed and CancelChannelCreation() must be called
36 // to cancel creation of channels for which the |callback| hasn't been called 34 // to cancel creation of channels for which the |callback| hasn't been called
37 // yet. 35 // yet.
38 virtual void CreateStreamChannel( 36 virtual void CreateChannel(const std::string& name,
39 const std::string& name, const StreamChannelCallback& callback) = 0; 37 const ChannelCreatedCallback& callback) = 0;
40 virtual void CreateDatagramChannel(
41 const std::string& name, const DatagramChannelCallback& callback) = 0;
42 38
43 // Cancels a pending CreateStreamChannel() or CreateDatagramChannel() 39 // Cancels a pending CreateChannel() operation for the named channel. If the
44 // operation for the named channel. If the channel creation already 40 // channel creation already completed then canceling it has no effect. When
45 // completed then canceling it has no effect. When shutting down 41 // shutting down this method must be called for each channel pending creation.
46 // this method must be called for each channel pending creation.
47 virtual void CancelChannelCreation(const std::string& name) = 0; 42 virtual void CancelChannelCreation(const std::string& name) = 0;
48 43
49 protected: 44 protected:
50 virtual ~ChannelFactory() {} 45 virtual ~ChannelFactory() {}
51 46
52 private: 47 private:
53 DISALLOW_COPY_AND_ASSIGN(ChannelFactory); 48 DISALLOW_COPY_AND_ASSIGN(ChannelFactory);
54 }; 49 };
55 50
56 } // namespace protocol 51 } // namespace protocol
57 } // namespace remoting 52 } // namespace remoting
58 53
59 #endif // REMOTING_PROTOCOL_CHANNEL_FACTORY_H_ 54 #endif // REMOTING_PROTOCOL_CHANNEL_FACTORY_H_
OLDNEW
« no previous file with comments | « remoting/protocol/channel_dispatcher_base.cc ('k') | remoting/protocol/channel_multiplexer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698