Factor painting code out of RenderBox into a new class called BoxPainter.

Source/core/rendering/RenderBoxModelObject.h

Index: Source/core/rendering/RenderBoxModelObject.h
diff --git a/Source/core/rendering/RenderBoxModelObject.h b/Source/core/rendering/RenderBoxModelObject.h
index 9bd701a61fb85b6e052b849acdb4d495d63b2660..e9377ce4ed71fb785406137905de2e6c4210ac76 100644
--- a/Source/core/rendering/RenderBoxModelObject.h
+++ b/Source/core/rendering/RenderBoxModelObject.h
@@ -245,9 +245,6 @@ protected:
 
     bool calculateHasBoxDecorations() const;
     void calculateBackgroundImageGeometry(const RenderLayerModelObject* paintContainer, const FillLayer&, const LayoutRect& paintRect, BackgroundImageGeometry&, RenderObject* = 0) const;
-    void getBorderEdgeInfo(class BorderEdge[], const RenderStyle*, bool includeLogicalLeftEdge = true, bool includeLogicalRightEdge = true) const;
-    bool borderObscuresBackgroundEdge(const FloatSize& contextScale) const;
-    bool borderObscuresBackground() const;
     RoundedRect backgroundRoundedRectAdjustedForBleedAvoidance(GraphicsContext*, const LayoutRect&, BackgroundBleedAvoidance, InlineFlowBox*, const LayoutSize&, bool includeLogicalLeftEdge, bool includeLogicalRightEdge) const;
     LayoutRect borderInnerRectAdjustedForBleedAvoidance(GraphicsContext*, const LayoutRect&, BackgroundBleedAvoidance) const;
 
@@ -262,11 +259,10 @@ protected:
 
     bool hasAutoHeightOrContainingBlockWithAutoHeight() const;
 
-    bool isDocumentElementWithOpaqueBackground() const;
-
+public:

[Stephen Chennney, 2014/09/09 16:14:37]

You're making a whole lot of stuff public now. It doesn't seem at all necessary.

[chrishtr, 2014/09/09 16:55:45]

isDocumentElementWithOpaqueBackground() is called from BoxPainter now. I did it
as a temporary measure while we refactor. Once the paint code in
RenderBoxModelObject is moved over, this won't be necessary. Added a FIXME in
this case.

     void paintRootBackgroundColor(const PaintInfo&, const LayoutRect&, const Color&);
+    bool isDocumentElementWithOpaqueBackground() const;
 
-public:
     static bool shouldAntialiasLines(GraphicsContext*);
 
     // For RenderBlocks and RenderInlines with m_style->styleType() == FIRST_LETTER, this tracks their remaining text fragments