Source/core/rendering/RenderBoxModelObject.h - Issue 550363004: Factor painting code out of RenderBox into a new class called BoxPainter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBoxModelObject.h

Issue 550363004: Factor painting code out of RenderBox into a new class called BoxPainter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix debug build. Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/RenderBox.h ('K') | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderBoxModelObject.cpp » ('j') | Source/core/rendering/style/BorderEdge.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/RenderBoxModelObject.h

diff --git a/Source/core/rendering/RenderBoxModelObject.h b/Source/core/rendering/RenderBoxModelObject.h

index 9bd701a61fb85b6e052b849acdb4d495d63b2660..9aeae662ca420a99e7dbf382d27b3b9a93753fe9 100644

--- a/Source/core/rendering/RenderBoxModelObject.h

+++ b/Source/core/rendering/RenderBoxModelObject.h

@@ -245,9 +245,6 @@ protected:

bool calculateHasBoxDecorations() const;

void calculateBackgroundImageGeometry(const RenderLayerModelObject* paintContainer, const FillLayer&, const LayoutRect& paintRect, BackgroundImageGeometry&, RenderObject* = 0) const;

- void getBorderEdgeInfo(class BorderEdge[], const RenderStyle*, bool includeLogicalLeftEdge = true, bool includeLogicalRightEdge = true) const;

- bool borderObscuresBackgroundEdge(const FloatSize& contextScale) const;

- bool borderObscuresBackground() const;

RoundedRect backgroundRoundedRectAdjustedForBleedAvoidance(GraphicsContext*, const LayoutRect&, BackgroundBleedAvoidance, InlineFlowBox*, const LayoutSize&, bool includeLogicalLeftEdge, bool includeLogicalRightEdge) const;

LayoutRect borderInnerRectAdjustedForBleedAvoidance(GraphicsContext*, const LayoutRect&, BackgroundBleedAvoidance) const;

@@ -262,11 +259,12 @@ protected:

bool hasAutoHeightOrContainingBlockWithAutoHeight() const;

- bool isDocumentElementWithOpaqueBackground() const;

+public:

void paintRootBackgroundColor(const PaintInfo&, const LayoutRect&, const Color&);

-public:

+ // FIXME: Slimming Paint: make this private again after moving paint code in this class to paint/

+ bool isDocumentElementWithOpaqueBackground() const;

Stephen Chennney 2014/09/09 19:16:48 I would move these methods up to the existing publ

chrishtr 2014/09/09 19:50:35 Done.

static bool shouldAntialiasLines(GraphicsContext*);

// For RenderBlocks and RenderInlines with m_style->styleType() == FIRST_LETTER, this tracks their remaining text fragments

« Source/core/rendering/RenderBox.h ('K') | « Source/core/rendering/RenderBox.cpp ('k') | Source/core/rendering/RenderBoxModelObject.cpp » ('j') | Source/core/rendering/style/BorderEdge.h » ('J')