Source/core/rendering/RenderFieldset.h - Issue 550363004: Factor painting code out of RenderBox into a new class called BoxPainter.

Side by Side Diff: Source/core/rendering/RenderFieldset.h

Issue 550363004: Factor painting code out of RenderBox into a new class called BoxPainter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/core/rendering/RenderBoxModelObject.h ('K') | « Source/core/rendering/RenderBoxModelObject.cpp ('k') | Source/core/rendering/RenderFieldset.cpp » ('j') | Source/core/rendering/RenderTable.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2000 Dirk Mueller (mueller@kde.org)	4 * (C) 2000 Dirk Mueller (mueller@kde.org)

5 * Copyright (C) 2004, 2006, 2009 Apple Inc. All rights reserved.	5 * Copyright (C) 2004, 2006, 2009 Apple Inc. All rights reserved.

6 *	6 *

7 * This library is free software; you can redistribute it and/or	7 * This library is free software; you can redistribute it and/or

8 * modify it under the terms of the GNU Library General Public	8 * modify it under the terms of the GNU Library General Public

9 * License as published by the Free Software Foundation; either	9 * License as published by the Free Software Foundation; either

10 * version 2 of the License, or (at your option) any later version.	10 * version 2 of the License, or (at your option) any later version.

(...skipping 28 matching lines...) Expand all Loading...
39 virtual const char* renderName() const OVERRIDE { return "RenderFieldSet"; }	39 virtual const char* renderName() const OVERRIDE { return "RenderFieldSet"; }

40 virtual bool isFieldset() const OVERRIDE { return true; }	40 virtual bool isFieldset() const OVERRIDE { return true; }

41	41

42 virtual RenderObject* layoutSpecialExcludedChild(bool relayoutChildren, Subt reeLayoutScope&) OVERRIDE;	42 virtual RenderObject* layoutSpecialExcludedChild(bool relayoutChildren, Subt reeLayoutScope&) OVERRIDE;

43	43

44 virtual void computePreferredLogicalWidths() OVERRIDE;	44 virtual void computePreferredLogicalWidths() OVERRIDE;

45 virtual bool avoidsFloats() const OVERRIDE { return true; }	45 virtual bool avoidsFloats() const OVERRIDE { return true; }

46	46

47 virtual void paintBoxDecorationBackground(PaintInfo&, const LayoutPoint&) OV ERRIDE;	47 virtual void paintBoxDecorationBackground(PaintInfo&, const LayoutPoint&) OV ERRIDE;

48 virtual void paintMask(PaintInfo&, const LayoutPoint&) OVERRIDE;	48 virtual void paintMask(PaintInfo&, const LayoutPoint&) OVERRIDE;

	49

	50 BoxPainter m_boxPainter;
	Stephen Chennney 2014/09/09 16:14:37 This is what I was getting at earlier. Ideally thi This is what I was getting at earlier. Ideally this would be a FieldsetPainter that derived from BoxPainter to implement the functionality. Or we use static painter methods. chrishtr 2014/09/09 16:55:45 I'm trying to avoid inheritance for implementing t Show quoted text On 2014/09/09 at 16:14:37, Stephen Chenney wrote: > This is what I was getting at earlier. Ideally this would be a FieldsetPainter that derived from BoxPainter to implement the functionality. Or we use static painter methods. I'm trying to avoid inheritance for implementing the paint code, and instead using a composition pattern. I think this will result in more understandable code. Right now this use of BoxPainter code is a little strange, because it's using BoxPainter as a helper library. Instead I expect we will end up with some shared libraries factored out of the painters. The change to this file is what seems a minimal step to unblock creating BoxPainter, we should refactor within paint/ later. Stephen Chennney 2014/09/09 19:16:48 Acknowledged. Show quoted text On 2014/09/09 16:55:45, chrishtr wrote: > On 2014/09/09 at 16:14:37, Stephen Chenney wrote: > > This is what I was getting at earlier. Ideally this would be a FieldsetPainter > that derived from BoxPainter to implement the functionality. Or we use static > painter methods. > > I'm trying to avoid inheritance for implementing the paint code, and instead > using a composition pattern. I think this will result in more understandable > code. Right now this use of BoxPainter code is a little strange, because it's > using BoxPainter as a helper library. Instead I expect we will end up with some > shared libraries factored out of the painters. > The change to this file is what seems a minimal step to unblock creating > BoxPainter, we should refactor within paint/ later. Acknowledged.
49 };	51 };

50	52

51 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderFieldset, isFieldset());	53 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderFieldset, isFieldset());

52	54

53 } // namespace blink	55 } // namespace blink

54	56

55 #endif // RenderFieldset_h	57 #endif // RenderFieldset_h

OLD	NEW