Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Side by Side Diff: Source/core/rendering/RenderImage.cpp

Issue 550363004: Factor painting code out of RenderBox into a new class called BoxPainter. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderFieldset.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2006 Allan Sandfeld Jensen (kde@carewolf.com)
6 * (C) 2006 Samuel Weinig (sam.weinig@gmail.com) 6 * (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) Research In Motion Limited 2011-2012. All rights reserved. 9 * Copyright (C) Research In Motion Limited 2011-2012. All rights reserved.
10 * 10 *
(...skipping 462 matching lines...) Expand 10 before | Expand all | Expand 10 after
473 bool RenderImage::foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect, unsigned) const 473 bool RenderImage::foregroundIsKnownToBeOpaqueInRect(const LayoutRect& localRect, unsigned) const
474 { 474 {
475 if (!m_imageResource->hasImage() || m_imageResource->errorOccurred()) 475 if (!m_imageResource->hasImage() || m_imageResource->errorOccurred())
476 return false; 476 return false;
477 if (m_imageResource->cachedImage() && !m_imageResource->cachedImage()->isLoa ded()) 477 if (m_imageResource->cachedImage() && !m_imageResource->cachedImage()->isLoa ded())
478 return false; 478 return false;
479 if (!contentBoxRect().contains(localRect)) 479 if (!contentBoxRect().contains(localRect))
480 return false; 480 return false;
481 EFillBox backgroundClip = style()->backgroundClip(); 481 EFillBox backgroundClip = style()->backgroundClip();
482 // Background paints under borders. 482 // Background paints under borders.
483 if (backgroundClip == BorderFillBox && style()->hasBorder() && !borderObscur esBackground()) 483 if (backgroundClip == BorderFillBox && style()->hasBorder() && !style()->bor derObscuresBackground())
484 return false; 484 return false;
485 // Background shows in padding area. 485 // Background shows in padding area.
486 if ((backgroundClip == BorderFillBox || backgroundClip == PaddingFillBox) && style()->hasPadding()) 486 if ((backgroundClip == BorderFillBox || backgroundClip == PaddingFillBox) && style()->hasPadding())
487 return false; 487 return false;
488 // Object-position may leave parts of the content box empty, regardless of t he value of object-fit. 488 // Object-position may leave parts of the content box empty, regardless of t he value of object-fit.
489 if (style()->objectPosition() != RenderStyle::initialObjectPosition()) 489 if (style()->objectPosition() != RenderStyle::initialObjectPosition())
490 return false; 490 return false;
491 // Object-fit may leave parts of the content box empty. 491 // Object-fit may leave parts of the content box empty.
492 ObjectFit objectFit = style()->objectFit(); 492 ObjectFit objectFit = style()->objectFit();
493 if (objectFit != ObjectFitFill && objectFit != ObjectFitCover) 493 if (objectFit != ObjectFitFill && objectFit != ObjectFitCover)
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
627 return 0; 627 return 0;
628 628
629 ImageResource* cachedImage = m_imageResource->cachedImage(); 629 ImageResource* cachedImage = m_imageResource->cachedImage();
630 if (cachedImage && cachedImage->image() && cachedImage->image()->isSVGImage( )) 630 if (cachedImage && cachedImage->image() && cachedImage->image()->isSVGImage( ))
631 return toSVGImage(cachedImage->image())->embeddedContentBox(); 631 return toSVGImage(cachedImage->image())->embeddedContentBox();
632 632
633 return 0; 633 return 0;
634 } 634 }
635 635
636 } // namespace blink 636 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderFieldset.cpp ('k') | Source/core/rendering/RenderObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698