webkit/tools/layout_tests/layout_package/test_shell_thread.py - Issue 55034: Support valgrinding layout tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/tools/layout_tests/layout_package/test_shell_thread.py

Issue 55034: Support valgrinding layout tests. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 11 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/tools/layout_tests/layout_package/test_shell_thread.py

===================================================================

--- webkit/tools/layout_tests/layout_package/test_shell_thread.py (revision 12713)

+++ webkit/tools/layout_tests/layout_package/test_shell_thread.py (working copy)

@@ -102,7 +102,13 @@

def StartTestShell(command, args):

"""Returns the process for a new test_shell started in layout-tests mode."""

- cmd = command + ['--layout-tests'] + args

+ cmd = []

+ # Hook for injecting valgrind or other runtime instrumentation,

+ # used by e.g. tools/valgrind/valgrind_tests.py.

+ wrapper = os.environ["BROWSER_WRAPPER"]

+ if wrapper != None:

+ cmd += [wrapper]

+ cmd += command + ['--layout-tests'] + args

return subprocess.Popen(cmd,

stdin=subprocess.PIPE,

stdout=subprocess.PIPE,