Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Side by Side Diff: Source/platform/BUILD.gn

Issue 550333003: Convert GN visibility to lists. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/modules/BUILD.gn ('k') | Source/platform/heap/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 import("//third_party/WebKit/Source/build/scripts/scripts.gni") 6 import("//third_party/WebKit/Source/build/scripts/scripts.gni")
7 import("//third_party/WebKit/Source/config.gni") 7 import("//third_party/WebKit/Source/config.gni")
8 import("//third_party/WebKit/Source/platform/platform.gni") 8 import("//third_party/WebKit/Source/platform/platform.gni")
9 import("//third_party/WebKit/Source/platform/platform_generated.gni") 9 import("//third_party/WebKit/Source/platform/platform_generated.gni")
10 10
11 # Most targets in this file are private actions so use that as the default. 11 # Most targets in this file are private actions so use that as the default.
12 visibility = ":*" 12 visibility = [ ":*" ]
13 13
14 heap_gypi = exec_script( 14 heap_gypi = exec_script(
15 "//build/gypi_to_gn.py", 15 "//build/gypi_to_gn.py",
16 [ rebase_path("heap/blink_heap.gypi") ], 16 [ rebase_path("heap/blink_heap.gypi") ],
17 "scope", 17 "scope",
18 [ "heap/blink_heap.gypi" ]) 18 [ "heap/blink_heap.gypi" ])
19 19
20 blink_platform_neon_files = [ 20 blink_platform_neon_files = [
21 "graphics/cpu/arm/WebGLImageConversionNEON.h", 21 "graphics/cpu/arm/WebGLImageConversionNEON.h",
22 "graphics/cpu/arm/filters/FEBlendNEON.h", 22 "graphics/cpu/arm/filters/FEBlendNEON.h",
23 "graphics/cpu/arm/filters/FECompositeArithmeticNEON.h", 23 "graphics/cpu/arm/filters/FECompositeArithmeticNEON.h",
24 "graphics/cpu/arm/filters/FEGaussianBlurNEON.h", 24 "graphics/cpu/arm/filters/FEGaussianBlurNEON.h",
25 "graphics/cpu/arm/filters/NEONHelpers.h", 25 "graphics/cpu/arm/filters/NEONHelpers.h",
26 ] 26 ]
27 27
28 # blink_common in blink_platform.gyp 28 # blink_common in blink_platform.gyp
29 component("blink_common") { 29 component("blink_common") {
30 visibility = "//third_party/WebKit/*" 30 visibility = [] # Allow re-assignment of list.
31 visibility = [ "//third_party/WebKit/*" ]
31 sources = [ 32 sources = [
32 "exported/WebCString.cpp", 33 "exported/WebCString.cpp",
33 "exported/WebString.cpp", 34 "exported/WebString.cpp",
34 "exported/WebCommon.cpp", 35 "exported/WebCommon.cpp",
35 ] 36 ]
36 37
37 defines = [ 38 defines = [
38 "BLINK_COMMON_IMPLEMENTATION=1", 39 "BLINK_COMMON_IMPLEMENTATION=1",
39 "INSIDE_BLINK", 40 "INSIDE_BLINK",
40 ] 41 ]
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 "--key-positions=*", 143 "--key-positions=*",
143 "-D", "-s", "2", 144 "-D", "-s", "2",
144 rebase_path(color_data_gperf, root_build_dir), 145 rebase_path(color_data_gperf, root_build_dir),
145 "--output-file=" + rebase_path(output_file, root_build_dir), 146 "--output-file=" + rebase_path(output_file, root_build_dir),
146 ] 147 ]
147 } 148 }
148 149
149 # This isn't strictly necessary since we can just add the deps to "platform", 150 # This isn't strictly necessary since we can just add the deps to "platform",
150 # but it helps to have the targets match the GYP build. 151 # but it helps to have the targets match the GYP build.
151 group("make_platform_generated") { 152 group("make_platform_generated") {
152 visibility = "//third_party/WebKit/Source/*" 153 visibility = [] # Allow re-assignment of list.
154 visibility = [ "//third_party/WebKit/Source/*" ]
153 deps = [ 155 deps = [
154 ":blink_common", 156 ":blink_common",
155 ":color_data", 157 ":color_data",
156 ":font_family_names", 158 ":font_family_names",
157 ":runtime_enabled_features", 159 ":runtime_enabled_features",
158 ] 160 ]
159 } 161 }
160 162
161 # TODO(brettw) Objective C Renaming postbuild steps on Mac. 163 # TODO(brettw) Objective C Renaming postbuild steps on Mac.
162 # blink_platform target in blink_platform.gyp 164 # blink_platform target in blink_platform.gyp
163 component("platform") { 165 component("platform") {
164 visibility = "//third_party/WebKit/*" 166 visibility = [] # Allow re-assignment of list.
167 visibility = [ "//third_party/WebKit/*" ]
165 output_name = "blink_platform" 168 output_name = "blink_platform"
166 169
167 sources = platform_files 170 sources = platform_files
168 sources -= blink_platform_neon_files 171 sources -= blink_platform_neon_files
169 172
170 # Add in the generated files. 173 # Add in the generated files.
171 sources += 174 sources +=
172 get_target_outputs(":font_family_names") + 175 get_target_outputs(":font_family_names") +
173 get_target_outputs(":runtime_enabled_features") + 176 get_target_outputs(":runtime_enabled_features") +
174 get_target_outputs(":color_data") 177 get_target_outputs(":color_data")
(...skipping 151 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 deps += [ "//third_party/ffmpeg" ] 329 deps += [ "//third_party/ffmpeg" ]
327 } 330 }
328 if (use_openmax_dl_fft) { 331 if (use_openmax_dl_fft) {
329 include_dirs += [ "//third_party/openmax_dl" ] 332 include_dirs += [ "//third_party/openmax_dl" ]
330 # TODO(GYP) 333 # TODO(GYP)
331 # deps += [ "//third_party/openmax_dl/dl" ] 334 # deps += [ "//third_party/openmax_dl/dl" ]
332 } 335 }
333 } 336 }
334 337
335 test("heap_unittests") { 338 test("heap_unittests") {
336 visibility = "//third_party/WebKit/*" 339 visibility = [] # Allow re-assignment of list.
340 visibility = [ "//third_party/WebKit/*" ]
337 output_name = "blink_heap_unittests" 341 output_name = "blink_heap_unittests"
338 342
339 sources = rebase_path(heap_gypi.platform_heap_test_files, ".", "heap") 343 sources = rebase_path(heap_gypi.platform_heap_test_files, ".", "heap")
340 sources += [ "heap/RunAllTests.cpp" ] 344 sources += [ "heap/RunAllTests.cpp" ]
341 345
342 configs += [ 346 configs += [
343 "//third_party/WebKit/Source/wtf:wtf_config", 347 "//third_party/WebKit/Source/wtf:wtf_config",
344 "//third_party/WebKit/Source:config", 348 "//third_party/WebKit/Source:config",
345 ] 349 ]
346 350
347 deps = [ 351 deps = [
348 ":platform", 352 ":platform",
349 "//base", 353 "//base",
350 "//base/allocator", 354 "//base/allocator",
351 "//base/test:test_support", 355 "//base/test:test_support",
352 "//testing/gmock", 356 "//testing/gmock",
353 "//testing/gtest", 357 "//testing/gtest",
354 "//third_party/WebKit/Source/wtf", 358 "//third_party/WebKit/Source/wtf",
355 "//third_party/WebKit/Source/wtf:test_support", 359 "//third_party/WebKit/Source/wtf:test_support",
356 ] 360 ]
357 } 361 }
358 362
359 test("platform_unittests") { 363 test("platform_unittests") {
360 visibility = "//third_party/WebKit/*" 364 visibility = [] # Allow re-assignment of list.
365 visibility = [ "//third_party/WebKit/*" ]
361 output_name = "blink_platform_unittests" 366 output_name = "blink_platform_unittests"
362 367
363 sources = platform_test_files 368 sources = platform_test_files
364 369
365 sources += [ "testing/RunAllTests.cpp" ] 370 sources += [ "testing/RunAllTests.cpp" ]
366 371
367 configs += [ 372 configs += [
368 "//third_party/WebKit/Source/wtf:wtf_config", 373 "//third_party/WebKit/Source/wtf:wtf_config",
369 "//third_party/WebKit/Source:config", 374 "//third_party/WebKit/Source:config",
370 ] 375 ]
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
404 #'cflags': ['-marm'], 409 #'cflags': ['-marm'],
405 # 'conditions': [ 410 # 'conditions': [
406 # ['OS=="android"', { 411 # ['OS=="android"', {
407 # 'cflags!': ['-mthumb'], 412 # 'cflags!': ['-mthumb'],
408 # }], 413 # }],
409 # ], 414 # ],
410 415
411 deps = [ ":blink_common" ] 416 deps = [ ":blink_common" ]
412 } 417 }
413 } 418 }
OLDNEW
« no previous file with comments | « Source/modules/BUILD.gn ('k') | Source/platform/heap/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698