Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Unified Diff: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc

Issue 550313002: Pop extensions out of the action overflow menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
diff --git a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
index b33776f0894c2cf0f2e4e871cf21374df474b512..5f0e25ddcb92187f699103ad3b34de6c32fe9220 100644
--- a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
+++ b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.cc
@@ -227,11 +227,20 @@ int BrowserActionOverflowMenuController::OnPerformDrop(
drop_data.index() < owner_->VisibleBrowserActions())
--drop_index;
+ // Move the extension in the model.
const extensions::Extension* extension =
extensions::ExtensionRegistry::Get(browser_->profile())->
enabled_extensions().GetByID(drop_data.id());
- extensions::ExtensionToolbarModel::Get(browser_->profile())->
- MoveExtensionIcon(extension, drop_index);
+ extensions::ExtensionToolbarModel* toolbar_model =
+ extensions::ExtensionToolbarModel::Get(browser_->profile());
+ if (browser_->profile()->IsOffTheRecord())
+ drop_index = toolbar_model->IncognitoIndexToOriginal(drop_index);
+ toolbar_model->MoveExtensionIcon(extension, drop_index);
+
+ // If the extension was moved to the overflow menu from the main bar, notify
+ // the owner.
+ if (drop_index >= owner_->VisibleBrowserActions())
+ owner_->NotifyActionMovedToOverflow();
if (for_drop_)
delete this;

Powered by Google App Engine
This is Rietveld 408576698