Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2041)

Unified Diff: chrome/browser/ui/views/toolbar/browser_actions_container.h

Issue 550313002: Pop extensions out of the action overflow menu (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed incognito mode Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/toolbar/browser_actions_container.h
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container.h b/chrome/browser/ui/views/toolbar/browser_actions_container.h
index f3702c5aa560c5c1824198a68836a2d4c9d4e201..da3004c06b425c71f0a995d38721faf5c319cb6f 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container.h
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container.h
@@ -187,6 +187,10 @@ class BrowserActionsContainer
void ExecuteExtensionCommand(const extensions::Extension* extension,
const extensions::Command& command);
+ // Notify the browser action container that an extension has been moved to
+ // the overflow container.
+ void NotifyActionMovedToOverflow();
+
// Add or remove an observer.
void AddObserver(BrowserActionsContainerObserver* observer);
void RemoveObserver(BrowserActionsContainerObserver* observer);
@@ -351,6 +355,9 @@ class BrowserActionsContainer
// mode). See class comments for details on the difference.
bool in_overflow_mode() const { return main_container_ != NULL; }
+ // Whether or not the container has been initialized.
+ bool initialized_;
+
// The vector of browser actions (icons/image buttons for each action). Note
// that not every BrowserAction in the ToolbarModel will necessarily be in
// this collection. Some extensions may be disabled in incognito windows.

Powered by Google App Engine
This is Rietveld 408576698