Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 55023005: Partial fix for Skia issue 1769: GenerateGMs crashing (out of memory) (Closed)

Created:
7 years, 1 month ago by jvanverth1
Modified:
7 years, 1 month ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Partial fix for Skia issue 1769: GenerateGMs crashing (out of memory) GenerateGMs was crashing because we were adding genID listeners for textures even when creation failed -- in this case the key generated is not valid, so when it comes time to purge it, it triggers an assert and then an apparent crash. The solution is to not add a genID listener in this case. This doesn't solve the problem of running out of memory, it just prevents it from causing a crash in Debug builds. BUG= Committed: http://code.google.com/p/skia/source/detail?r=12062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/gpu/SkGr.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jvanverth1
7 years, 1 month ago (2013-10-31 19:45:25 UTC) #1
mtklein
On 2013/10/31 19:45:25, JimVV wrote: lgtm Ah, thank you. My bad.
7 years, 1 month ago (2013-10-31 19:57:46 UTC) #2
bsalomon
lgtm
7 years, 1 month ago (2013-10-31 19:58:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/jvanverth@google.com/55023005/1
7 years, 1 month ago (2013-10-31 19:59:50 UTC) #4
robertphillips
lgtm
7 years, 1 month ago (2013-10-31 20:00:20 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-10-31 20:22:50 UTC) #6
Message was sent while issue was closed.
Change committed as 12062

Powered by Google App Engine
This is Rietveld 408576698