Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(975)

Unified Diff: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java

Issue 55023003: Issue 14653. It is compile-time error to use unresolved identifier for annotation. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
diff --git a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
index 4592378ab2f198e8455c5252f9430069b22ae59e..fc91293b46645b01649ea340c8bf131d186eea73 100644
--- a/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
+++ b/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/resolver/ElementResolver.java
@@ -1141,6 +1141,10 @@ public class ElementResolver extends SimpleASTVisitor<Void> {
identifier,
identifier.getName(),
prefixElement.getName());
+ } else if (node.getParent() instanceof Annotation) {
+ Annotation annotation = (Annotation) node.getParent();
+ resolver.reportError(CompileTimeErrorCode.INVALID_ANNOTATION, annotation);
+ return null;
} else {
resolver.reportError(
StaticWarningCode.UNDEFINED_GETTER,
@@ -1307,6 +1311,9 @@ public class ElementResolver extends SimpleASTVisitor<Void> {
// TODO(brianwilkerson) Recover from this error.
if (isConstructorReturnType(node)) {
resolver.reportError(CompileTimeErrorCode.INVALID_CONSTRUCTOR_NAME, node);
+ } else if (node.getParent() instanceof Annotation) {
+ Annotation annotation = (Annotation) node.getParent();
+ resolver.reportError(CompileTimeErrorCode.INVALID_ANNOTATION, annotation);
} else {
resolver.reportErrorProxyConditionalAnalysisError(
resolver.getEnclosingClass(),

Powered by Google App Engine
This is Rietveld 408576698