Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: tools/testing/dart/test_suite.dart

Issue 55023002: Pass sharedOptions to the compilation command of a browser test. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for enumerating and preparing tests. 6 * Classes and methods for enumerating and preparing tests.
7 * 7 *
8 * This library includes: 8 * This library includes:
9 * 9 *
10 * - Creating tests by listing all the Dart files in certain directories, 10 * - Creating tests by listing all the Dart files in certain directories,
(...skipping 1157 matching lines...) Expand 10 before | Expand all | Expand 10 after
1168 assert (['dart2js', 'dart2dart'].contains(compiler)); 1168 assert (['dart2js', 'dart2dart'].contains(compiler));
1169 String executable = compilerPath; 1169 String executable = compilerPath;
1170 List<String> args = TestUtils.standardOptions(configuration); 1170 List<String> args = TestUtils.standardOptions(configuration);
1171 String packageRoot = 1171 String packageRoot =
1172 packageRootArgument(optionsFromFile['packageRoot']); 1172 packageRootArgument(optionsFromFile['packageRoot']);
1173 if (packageRoot != null) { 1173 if (packageRoot != null) {
1174 args.add(packageRoot); 1174 args.add(packageRoot);
1175 } 1175 }
1176 args.add('--out=$outputFile'); 1176 args.add('--out=$outputFile');
1177 args.add(inputFile); 1177 args.add(inputFile);
1178 args.addAll(optionsFromFile['sharedOptions']);
1178 if (executable.endsWith('.dart')) { 1179 if (executable.endsWith('.dart')) {
1179 // Run the compiler script via the Dart VM. 1180 // Run the compiler script via the Dart VM.
1180 args.insert(0, executable); 1181 args.insert(0, executable);
1181 executable = dartShellFileName; 1182 executable = dartShellFileName;
1182 } 1183 }
1183 return CommandBuilder.instance.getCompilationCommand( 1184 return CommandBuilder.instance.getCompilationCommand(
1184 compiler, outputFile, !useSdk, 1185 compiler, outputFile, !useSdk,
1185 dart2JsBootstrapDependencies, compilerPath, args, configurationDir); 1186 dart2JsBootstrapDependencies, compilerPath, args, configurationDir);
1186 } 1187 }
1187 1188
(...skipping 872 matching lines...) Expand 10 before | Expand all | Expand 10 after
2060 * $pass tests are expected to pass 2061 * $pass tests are expected to pass
2061 * $failOk tests are expected to fail that we won't fix 2062 * $failOk tests are expected to fail that we won't fix
2062 * $fail tests are expected to fail that we should fix 2063 * $fail tests are expected to fail that we should fix
2063 * $crash tests are expected to crash that we should fix 2064 * $crash tests are expected to crash that we should fix
2064 * $timeout tests are allowed to timeout 2065 * $timeout tests are allowed to timeout
2065 * $compileErrorSkip tests are skipped on browsers due to compile-time error 2066 * $compileErrorSkip tests are skipped on browsers due to compile-time error
2066 """; 2067 """;
2067 print(report); 2068 print(report);
2068 } 2069 }
2069 } 2070 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698