CSP: Separate side-effects of parsing from the parsing code.

CSP: Separate side-effects of parsing from the parsing code.

This patch shouldn't have any practical effect on CSP, but it will make
it straightforward to separate side-effects from parsing in a future
patch.

BUG=411889
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181632

[Mike West, 2014-09-08 14:47:26]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2014-09-08 14:47:27]

This depends on https://codereview.chromium.org/549163003/; I'll run it through
the bots once that patch lands.

WDYT?

-mike

[jochen (gone - plz use gerrit), 2014-09-09 08:08:34]

https://codereview.chromium.org/550223002/diff/1/Source/core/frame/csp/Conten...
File Source/core/frame/csp/ContentSecurityPolicy.cpp (right):

https://codereview.chromium.org/550223002/diff/1/Source/core/frame/csp/Conten...
Source/core/frame/csp/ContentSecurityPolicy.cpp:153:
document->setReferrerPolicy(m_referrerPolicy);
should this only be done if didSetReferrerPolicy() is true?

https://codereview.chromium.org/550223002/diff/1/Source/core/frame/csp/Conten...
File Source/core/frame/csp/ContentSecurityPolicy.h (right):

https://codereview.chromium.org/550223002/diff/1/Source/core/frame/csp/Conten...
Source/core/frame/csp/ContentSecurityPolicy.h:101: void didReceiveHeader(const
String&, ContentSecurityPolicyHeaderType, ContentSecurityPolicyHeaderSource,
bool shouldApplySideEffects = true);
can this be an enum instead of a bool?

https://codereview.chromium.org/550223002/diff/1/Source/core/frame/csp/Conten...
Source/core/frame/csp/ContentSecurityPolicy.h:101: void didReceiveHeader(const
String&, ContentSecurityPolicyHeaderType, ContentSecurityPolicyHeaderSource,
bool shouldApplySideEffects = true);
can this be an enum instead of a bool?

[Mike West, 2014-09-09 09:12:02]

Thanks!

Mind taking another look?

https://codereview.chromium.org/550223002/diff/1/Source/core/frame/csp/Conten...
File Source/core/frame/csp/ContentSecurityPolicy.cpp (right):

https://codereview.chromium.org/550223002/diff/1/Source/core/frame/csp/Conten...
Source/core/frame/csp/ContentSecurityPolicy.cpp:153:
document->setReferrerPolicy(m_referrerPolicy);
On 2014/09/09 08:08:33, jochen wrote:
> should this only be done if didSetReferrerPolicy() is true?

Yes!

https://codereview.chromium.org/550223002/diff/1/Source/core/frame/csp/Conten...
File Source/core/frame/csp/ContentSecurityPolicy.h (right):

https://codereview.chromium.org/550223002/diff/1/Source/core/frame/csp/Conten...
Source/core/frame/csp/ContentSecurityPolicy.h:101: void didReceiveHeader(const
String&, ContentSecurityPolicyHeaderType, ContentSecurityPolicyHeaderSource,
bool shouldApplySideEffects = true);
On 2014/09/09 08:08:34, jochen wrote:
> can this be an enum instead of a bool?

Certainly (though I intend to drop it entirely in a future patch once the
separation is more complete).

[jochen (gone - plz use gerrit), 2014-09-09 09:12:49]

lgtm

[Mike West, 2014-09-09 10:11:51]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2014-09-09 10:12:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mkwst@chromium.org/550223002/20001

[commit-bot: I haz the power, 2014-09-09 11:15:43]

Committed patchset #2 (id:20001) as 181632