Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 550213002: android_webview: stop using system ashmem. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 3 months ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

android_webview: stop using system ashmem. To support unbundled updates we need to stop depending on system libraries. Disable using the system ashmem APIs in libcutils and instead link Chromium's copy, and remove support for using the version in libcutils as there are no other users. This increases binary size by <1KB. BUG=409851 Committed: https://crrev.com/3acfbb2b8bed0d78aa4af78c5e34e289122b79e5 Cr-Commit-Position: refs/heads/master@{#293916}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -43 lines) Patch
M android_webview/tools/known_issues.py View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/ashmem/BUILD.gn View 1 chunk +5 lines, -15 lines 0 comments Download
M third_party/ashmem/ashmem.gyp View 1 chunk +4 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Torne
6 years, 3 months ago (2014-09-08 14:48:14 UTC) #2
Primiano Tucci (use gerrit)
lgtm
6 years, 3 months ago (2014-09-08 16:03:31 UTC) #3
Torne
Digit, are you intending to still be the owner of third_party/ashmem? If so can you ...
6 years, 3 months ago (2014-09-08 16:07:26 UTC) #5
digit1
On 2014/09/08 16:07:26, Torne wrote: lgtm > Digit, are you intending to still be the ...
6 years, 3 months ago (2014-09-09 00:01:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/550213002/1
6 years, 3 months ago (2014-09-09 09:45:03 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0e9482bbe9ab771030c4f79241000bc6c900bf62
6 years, 3 months ago (2014-09-09 10:50:34 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:52:40 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3acfbb2b8bed0d78aa4af78c5e34e289122b79e5
Cr-Commit-Position: refs/heads/master@{#293916}

Powered by Google App Engine
This is Rietveld 408576698