Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1493)

Unified Diff: content/public/common/manifest.h

Issue 550173002: Implement ManifestParser in content/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@manifest_fetcher
Patch Set: add ctor/dtor Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/manifest.h
diff --git a/content/public/common/manifest.h b/content/public/common/manifest.h
new file mode 100644
index 0000000000000000000000000000000000000000..889dd4c2bd0bfd9395642dc41dcc1ff1927abbfb
--- /dev/null
+++ b/content/public/common/manifest.h
@@ -0,0 +1,33 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_COMMON_MANIFEST_H_
+#define CONTENT_PUBLIC_COMMON_MANIFEST_H_
+
+#include "base/strings/nullable_string16.h"
+#include "content/common/content_export.h"
+
+namespace content {
+
+// The Manifest structure is an internal representation of the Manifest file
+// described in the "Manifest for Web Application" document:
+// http://w3c.github.io/manifest/
+struct CONTENT_EXPORT Manifest {
+ Manifest();
jochen (gone - plz use gerrit) 2014/09/12 11:55:18 ctor should take paramters for name and short_name
mlamouri (slow - plz ping) 2014/09/12 12:05:19 Why? Those members might or might not be present i
jochen (gone - plz use gerrit) 2014/09/12 12:09:40 currently, the parser always sets both fields, and
mlamouri (slow - plz ping) 2014/09/12 12:16:47 What do you mean by "that's how we do structs"? Mo
+ ~Manifest();
+
+ // Returns whether this Manifest had no attribute set. A newly created
+ // Manifest is always empty.
+ bool IsEmpty() const;
+
+ // Null if the parsing failed or the field was not present.
+ base::NullableString16 name;
+
+ // Null if the parsing failed or the field was not present.
+ base::NullableString16 short_name;
+};
+
+} // namespace content
+
+#endif // CONTENT_PUBLIC_COMMON_MANIFEST_H_

Powered by Google App Engine
This is Rietveld 408576698