Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 550113003: Remove android system expat support. (Closed)

Created:
6 years, 3 months ago by Torne
Modified:
6 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove android system expat support. Clean up the gyp/gn files by removing support for linking to the android system expat. We don't intend to support this in future and the android_src variable it depends on will be removed soon. BUG=409851 Committed: https://crrev.com/4898820bd13a57512c5b714cf8cdebc8a698332c Cr-Commit-Position: refs/heads/master@{#293843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M third_party/expat/BUILD.gn View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/expat/expat.gyp View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Torne
Brett, does the change to the GN file here look right?
6 years, 3 months ago (2014-09-08 10:57:55 UTC) #2
Torne
6 years, 3 months ago (2014-09-08 14:36:43 UTC) #4
Primiano Tucci (use gerrit)
lgtm
6 years, 3 months ago (2014-09-08 14:46:16 UTC) #5
brettw
lgtm
6 years, 3 months ago (2014-09-08 20:06:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/550113003/1
6 years, 3 months ago (2014-09-08 20:28:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as c8347ceeb49536801c45128ec1f1d44ee393efae
6 years, 3 months ago (2014-09-09 03:40:53 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:50:01 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4898820bd13a57512c5b714cf8cdebc8a698332c
Cr-Commit-Position: refs/heads/master@{#293843}

Powered by Google App Engine
This is Rietveld 408576698