[turbofan] Tests and fixes for ARM64 load/store with immediate offset.

[turbofan] Tests and fixes for ARM64 load/store with immediate offset.

R=bmeurer@chromium.org, ulan@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=23906

[baptiste.afsa1, 2014-09-08 10:38:38]

PTAL

[Benedikt Meurer, 2014-09-09 05:02:37]

https://codereview.chromium.org/550113002/diff/1/src/arm64/assembler-arm64.h
File src/arm64/assembler-arm64.h (right):

https://codereview.chromium.org/550113002/diff/1/src/arm64/assembler-arm64.h#...
src/arm64/assembler-arm64.h:1853: static bool IsImmLSUnscaled(ptrdiff_t offset);
Why ptrdiff_t here? It looks like you really want to use int64_t. ptrdiff_t
should only be used for distance between pointers to the same array.

[baptiste.afsa1, 2014-09-10 14:40:23]

On 2014/09/09 05:02:37, Benedikt Meurer wrote:
> https://codereview.chromium.org/550113002/diff/1/src/arm64/assembler-arm64.h
> File src/arm64/assembler-arm64.h (right):
> 
>
https://codereview.chromium.org/550113002/diff/1/src/arm64/assembler-arm64.h#...
> src/arm64/assembler-arm64.h:1853: static bool IsImmLSUnscaled(ptrdiff_t
offset);
> Why ptrdiff_t here? It looks like you really want to use int64_t. ptrdiff_t
> should only be used for distance between pointers to the same array.

Indeed the use of ptrdiff_t insn't completely right here and int64_t makes more
sense. I've uploaded a new patch (issue 559073003). After that I'll update this
one.

[baptiste.afsa1, 2014-09-11 15:08:33]

I've uploaded a new patch now that we don't need the cast to ptrdiff_t.

[Benedikt Meurer, 2014-09-12 05:50:00]

lgtm

[baptiste.afsa1, 2014-09-12 09:31:33]

Committed patchset #2 (id:20001) manually as 23906 (presubmit successful).