Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 550103004: Revert of Teach bot_update to support patching deps in solutions other than the patch_root (Closed)

Created:
6 years, 3 months ago by Ryan Tseng
Modified:
6 years, 3 months ago
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Revert of Teach bot_update to support patching deps in solutions other than the patch_root (patchset #2 id:20001 of https://codereview.chromium.org/552763002/) Reason for revert: Lots of bot_update failures on the waterfall. I don't see how this could've caused it yet, but gonna speculatively revert. Original issue's description: > Teach bot_update to support patching deps in solutions other than the patch_root > > R=hinoka@chromium.org, kjellander@chromium.org > BUG=411434 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291858 TBR=hinoka@chromium.org,kjellander@chromium.org,agable@chromium.org NOTREECHECKS=true NOTRY=true BUG=411434 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291860

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M scripts/slave/bot_update.py View 2 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ryan Tseng
Created Revert of Teach bot_update to support patching deps in solutions other than the patch_root
6 years, 3 months ago (2014-09-08 18:57:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/550103004/1
6 years, 3 months ago (2014-09-08 18:58:14 UTC) #2
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 18:59:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 291860

Powered by Google App Engine
This is Rietveld 408576698